filipg/geval
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Filter out NaN values so that sorting is not poisoned

Browse Source
This commit is contained in:
Filip Graliński 2019-02-01 12:32:56 +01:00
parent c05e094d87
commit ad5d614f48
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/GEval/LineByLine.hs
View File

@ -97,6 +97,7 @@ runWorstFeatures ordering spec bbdo = runLineByLineGeneralized ordering' spec (w
worstFeaturesPipeline :: Bool -> GEvalSpecification -> BlackBoxDebuggingOptions -> ConduitT LineRecord Void (ResourceT IO) () worstFeaturesPipeline :: Bool -> GEvalSpecification -> BlackBoxDebuggingOptions -> ConduitT LineRecord Void (ResourceT IO) ()
worstFeaturesPipeline reversed spec bbdo = rank (lessByMetric reversed $ gesMainMetric spec) worstFeaturesPipeline reversed spec bbdo = rank (lessByMetric reversed $ gesMainMetric spec)
.| evalStateC 0 (extractFeaturesAndPValues spec bbdo) .| evalStateC 0 (extractFeaturesAndPValues spec bbdo)
.| CC.filter (\(FeatureWithPValue _ p _ _) -> not $ isNaN p) -- NaN values would poison sorting
.| gobbleAndDo (sortBy featureOrder) .| gobbleAndDo (sortBy featureOrder)
.| filtreCartesian (bbdoCartesian bbdo) .| filtreCartesian (bbdoCartesian bbdo)
.| CL.map (encodeUtf8 . formatFeatureWithPValue) .| CL.map (encodeUtf8 . formatFeatureWithPValue)