From 04257e9054a7cd967ddd9659925dea57c189614b Mon Sep 17 00:00:00 2001 From: kalmar Date: Wed, 17 May 2017 11:47:59 +0200 Subject: [PATCH] short-circuting -> proper if...ends --- src/GroupRings.jl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/GroupRings.jl b/src/GroupRings.jl index f832d8a..a53393a 100644 --- a/src/GroupRings.jl +++ b/src/GroupRings.jl @@ -298,15 +298,20 @@ function create_pm{T<:GroupElem}(basis::Vector{T}, basis_dict::Dict{T, Int}, end function complete(A::GroupRing) - isdefined(A, :basis) || A.basis = collect(elements(A.group)) - isdefined(A, :basis_dict) || A.basis_dict = reverse_dict(A.basis) + if !isdefined(A, :basis) + A.basis = collect(elements(A.group)) + end + if !isdefined(A, :basis_dict) + A.basis_dict = reverse_dict(A.basis) + end if !isdefined(A, :pm) A.pm = try - create_pm(basis, basis_dict) + create_pm(A.basis, A.basis_dict) catch err - isa(err, KeyError) && throw("Product is not supported on basis!")) + isa(err, KeyError) && throw("Product is not supported on basis") throw(err) end + end return A end