From 13fa9962a950b0497fd5d8c7a3b981c6bbfcbdd2 Mon Sep 17 00:00:00 2001 From: kalmar Date: Fri, 21 Jul 2017 17:33:29 +0200 Subject: [PATCH] input similar directly into mul! --- src/GroupRings.jl | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/GroupRings.jl b/src/GroupRings.jl index fc44dcf..bc826cd 100644 --- a/src/GroupRings.jl +++ b/src/GroupRings.jl @@ -399,8 +399,7 @@ function *{T<:Number}(X::GroupRingElem{T}, Y::GroupRingElem{T}, check::Bool=true result = parent(X)(similar(X.coeffs)) result = mul!(result, X, Y) else - result = similar(X.coeffs) - result = mul!(result, X.coeffs, Y.coeffs, parent(X).pm) + result = mul!(similar(X.coeffs), X.coeffs, Y.coeffs, parent(X).pm) result = GroupRingElem(result, parent(X)) end return result @@ -422,8 +421,7 @@ function *{T<:Number, S<:Number}(X::GroupRingElem{T}, Y::GroupRingElem{S}, check result = convert(TT, result) result = mul!(result, X, Y) else - result = similar(X.coeffs) - result = convert(TT, result) + result = convert(TT, similar(X.coeffs)) result = mul!(result, X.coeffs, Y.coeffs, parent(X).pm) result = GroupRingElem(result, parent(X)) end