kalmar/GroupRings.jl
1
0
Fork 0
mirror of https://github.com/kalmarek/GroupRings.jl.git synced 2024-11-14 21:25:28 +01:00
Code Issues Releases Wiki Activity

replace init kw. by fastm in GroupRing constructor

Browse Source
This commit is contained in:
kalmar 2017-07-25 14:43:04 +02:00
parent 2c4a7561c4
commit 75627514fd
1 changed files with 22 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/GroupRings.jl
View File

@ -17,18 +17,9 @@ type GroupRing{Gr<:Group, T<:GroupElem} <: Ring
basis_dict::Dict{T, Int}
pm::Array{Int,2}
function GroupRing(G::Group, basis::Vector{T}; init::Bool=false)
function GroupRing(G::Group, basis::Vector{T}; fastm::Bool=false)
RG = new(G, basis, reverse_dict(basis))
if init
RG.pm = try
create_pm(RG.basis, RG.basis_dict)
catch err
isa(err, KeyError) && throw("Product is not supported on basis")
throw(err)
end
else
RG.pm = zeros(Int, length(basis), length(basis))
end
fastm && fastm!(RG)
return RG
end
@ -43,8 +34,8 @@ type GroupRing{Gr<:Group, T<:GroupElem} <: Ring
end
end
GroupRing{Gr<:Group, T<:GroupElem}(G::Gr, basis::Vector{T}; init=false) =
GroupRing{Gr, T}(G, basis, init=init)
GroupRing{Gr<:Group, T<:GroupElem}(G::Gr, basis::Vector{T}; fastm::Bool=true) =
GroupRing{Gr, T}(G, basis, fastm=fastm)
GroupRing{Gr<:Group, T<:GroupElem}(G::Gr, b::Vector{T}, b_d::Dict{T,Int}, pm::Array{Int,2}) = GroupRing{Gr, T}(G, b, b_d, pm)
@ -101,8 +92,8 @@ function GroupRingElem{T<:Number}(c::AbstractVector{T}, RG::GroupRing)
return GroupRingElem{T}(c, RG)
end
function GroupRing(G::Group; init::Bool=false)
return GroupRing(G, [elements(G)...], init=init)
function GroupRing(G::Group; fastm::Bool=false)
return GroupRing(G, [elements(G)...], fastm=fastm)
end
function GroupRing(G::Group, basis::Vector, pm::Array{Int,2})
@ -520,4 +511,20 @@ function complete!(RG::GroupRing)
return RG
end
function fastm!(RG::GroupRing; fill::Bool=false)
isdefined(RG, :basis) || throw("For baseless Group Rings You need to provide pm.")
isdefined(RG, :pm) && return RG
if fill
RG.pm = try
create_pm(RG.basis, RG.basis_dict)
catch err
isa(err, KeyError) && throw("Product is not supported on basis, $err.")
throw(err)
end
else
RG.pm = zeros(Int, length(RG.basis), length(RG.basis))
end
return RG
end
end # of module GroupRings