kalmar
/
GroupRings.jl
mirror of https://github.com/kalmarek/GroupRings.jl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

AA promote_rule is not symmetric by design

This commit is contained in:
kalmarek 2019-06-07 18:49:51 +02:00
parent 9e5a307ee3
commit 9ff0d68650
2 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/AARing_interface_conformance.jl
View File

@ -3,6 +3,10 @@ using AbstractAlgebra
has_base_ring(R::AbstractAlgebra.NCRing) = base_ring(R) != Union{}
function AbstractAlgebra.promote_rule(::Type{S}, ::Type{T}) where {S <: Real, T <: Real}
return Base.promote_rule(S, T)
end
function test_data_type(f,g)
@testset "Data type" begin
f,g = deepcopy(f), deepcopy(g)
@ -229,16 +233,23 @@ function test_promote_rules(f,g)
f,g = deepcopy(f), deepcopy(g)
@testset "promote_rules" begin
@test_broken AbstractAlgebra.promote_rule(typeof(f), Int16) == typeof(f)
@test_broken promote_rule(typeof(f), BigInt) == typeof(f)
function test_promotes(F::Type, I::Type)
@testset "Promote_type with $I" begin
@test AbstractAlgebra.promote_rule(F, I) isa Type
@test AbstractAlgebra.promote_rule(F, I) != Union{}
end
end
test_promotes(typeof(f), Int16)
test_promotes(typeof(f), Int)
test_promotes(typeof(f), typeof(g))
@test AbstractAlgebra.promote_rule(typeof(f), typeof(g)) == typeof(f)
@test AbstractAlgebra.promote_rule(typeof(g), typeof(f)) == typeof(f)
if has_base_ring(parent(f))
S = base_ring(parent(f))
test_promotes(typeof(f), elem_type(S))
@test AbstractAlgebra.promote_rule(typeof(f), elem_type(S)) == typeof(f)
@test AbstractAlgebra.promote_rule(elem_type(S), typeof(f)) == typeof(f)
end
end
end

9
test/runtests.jl
View File

@ -4,13 +4,14 @@ using AbstractAlgebra
using GroupRings
using SparseArrays
@testset "Group Rings tests" begin
include("AARing_interface_conformance.jl")
@testset "Group Rings tests" begin
include("unittests.jl")
include("usetests.jl")
let
include("AARing_interface_conformance.jl")
R = AbstractAlgebra.zz
G = PermGroup(4)
@ -19,8 +20,6 @@ using SparseArrays
X = rand(RG, 0.2, -3:3)
Y = rand(RG, 0.4, -1:1)
# test_ringinterface(X, Y)
test_promote_rules(X, Y)
test_ringinterface(X, Y)
end
end