From 9225d2153f650cd788added4ec97d6a5749194d1 Mon Sep 17 00:00:00 2001
From: kalmarek <kalmar@amu.edu.pl>
Date: Tue, 19 Nov 2019 11:30:29 +0100
Subject: [PATCH] use Base.one instead of (::Group)()

---
 src/GroupRings.jl |  8 ++++----
 test/runtests.jl  | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/GroupRings.jl b/src/GroupRings.jl
index b7c9820..1908de2 100644
--- a/src/GroupRings.jl
+++ b/src/GroupRings.jl
@@ -53,7 +53,7 @@ mutable struct GroupRingElem{T, A<:AbstractVector, GR<:GroupRing} <: NCRingElem
             "Can't create GroupRingElem -- lengths differ: length(c) =
             $(length(c)) != $(length(RG.basis)) = length(RG.basis)")
          else
-            @warn("Basis of the GroupRing is not defined.")
+            # @warn("Basis of the GroupRing is not defined.")
          end
       end
       return new{T, A, GR}(c, RG)
@@ -114,7 +114,7 @@ end
 # sparse storage:
 
 zero(RG::GroupRing, T::Type=Int) = RG(T)
-one(RG::GroupRing, T::Type=Int) = RG(RG.group(), T)
+one(RG::GroupRing, T::Type=Int) = RG(one(RG.group), T)
 one(RG::GroupRing{<:AbstractAlgebra.NCRing}, T::Type=Int) = RG(one(RG.group), T)
 
 function (RG::GroupRing)(T::Type=Int)
@@ -124,7 +124,7 @@ end
 
 function (RG::GroupRing)(i::Int, T::Type=Int)
    elt = RG(T)
-   elt[RG.group()] = i
+   elt[one(RG.group)] = i
    return elt
 end
 
@@ -229,7 +229,7 @@ function show(io::IO, X::GroupRingElem)
    RG = parent(X)
    T = eltype(X.coeffs)
    if X.coeffs == zero(X.coeffs)
-      print(io, "$(zero(T))*$((RG.group)())")
+      print(io, "$(zero(T))*$(one(RG.group))")
    elseif isdefined(RG, :basis)
       non_zeros = ((X.coeffs[i], RG.basis[i]) for i in findall(!iszero, X.coeffs))
       elts = String[]
diff --git a/test/runtests.jl b/test/runtests.jl
index 7da8e90..4a50e1e 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -49,7 +49,7 @@ using SparseArrays
       S = gens(F)
       append!(S, [inv(s) for s in S])
 
-      basis, sizes = Groups.generate_balls(S, F(), radius=4)
+      basis, sizes = Groups.generate_balls(S, one(F), radius=4)
       d = GroupRings.reverse_dict(basis)
       @test_throws KeyError create_pm(basis)
       pm = create_pm(basis, d, sizes[2])
@@ -67,7 +67,7 @@ using SparseArrays
       GroupRings.complete!(RF)
       @test count(!iszero, RF.pm) == 45469
 
-      g = B()
+      g = zero(B)
       s = S[2]
       g[s] = 1
       @test g == B(s)
@@ -217,7 +217,7 @@ using SparseArrays
          @test aug(z) == 0
 
          @test supp(z) == parent(z).basis
-         @test supp(RG(1) + RG(perm"(2,3)")) == [G(), perm"(2,3)"]
+         @test supp(RG(1) + RG(perm"(2,3)")) == [one(G), perm"(2,3)"]
          @test supp(a) == [perm"(3)", perm"(2,3)", perm"(1,2,3)"]
 
       end
@@ -228,8 +228,8 @@ using SparseArrays
          RG = GroupRing(G, cachedmul=true)
          RG2 = GroupRing(G, cachedmul=false)
 
-         Z = RG()
-         W = RG()
+         Z = zero(RG)
+         W = zero(RG)
 
          for g in [rand(G) for _ in 1:30]
             X = RG(g)
@@ -258,7 +258,7 @@ using SparseArrays
       S = G.(G.gens)
       S = [S; inv.(S)]
 
-      ID = G()
+      ID = one(G)
       RADIUS=3
       @time E_R, sizes = Groups.generate_balls(S, ID, radius=2*RADIUS);
       @test sizes == [9, 65, 457, 3201, 22409, 156865]