From 8661781c92883f0ff09ca9e328200cc685faa366 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Fri, 3 Nov 2017 16:39:01 +0100 Subject: [PATCH 1/3] changes in docs --- src/GroupRings.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/GroupRings.jl b/src/GroupRings.jl index 45cbc16..4ba3c69 100644 --- a/src/GroupRings.jl +++ b/src/GroupRings.jl @@ -339,8 +339,8 @@ doc""" X::AbstractVector, Y::AbstractVector, pm::Array{Int,2}) -> The most specialised multiplication for `X` and `Y` (`coeffs` of -> `GroupRingElems`) using multiplication table `pm`. +> The most specialised multiplication for `X` and `Y` (intended for `coeffs` of +> `GroupRingElems`), using multiplication table `pm`. > Notes: > * this method will silently produce false results if `X[k]` is non-zero for > `k > size(pm,1)`. @@ -377,7 +377,7 @@ doc""" > In-place multiplication for `GroupRingElem`s `X` and `Y`. > `mul!` will make use the initialised entries of `pm` attribute of > `parent(X)::GroupRing` (if available), and will compute and store in `pm` the -> remaining products. +> remaining products necessary to perform the multiplication. > The method will fail with `KeyError` if product `X*Y` is not supported on > `parent(X).basis`. """ From 2c45b70eac8a3458e1650d1ae211bb013517c882 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Fri, 3 Nov 2017 16:39:18 +0100 Subject: [PATCH 2/3] remove type annotation --- src/GroupRings.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/GroupRings.jl b/src/GroupRings.jl index 4ba3c69..3c84198 100644 --- a/src/GroupRings.jl +++ b/src/GroupRings.jl @@ -412,9 +412,9 @@ function mul!{T}(result::GroupRingElem{T}, X::GroupRingElem, Y::GroupRingElem) end end else - for j::Int in 1:lY + for j in 1:lY if Y.coeffs[j] != z - for i::Int in 1:lX + for i in 1:lX if X.coeffs[i] != z result[RG.basis[i]*RG.basis[j]] += X[i]*Y[j] end From a78f6bedce2935b70beed21de8df0f95607b815d Mon Sep 17 00:00:00 2001 From: kalmarek Date: Wed, 8 Nov 2017 09:07:36 +0100 Subject: [PATCH 3/3] allow precompilation of the module --- src/GroupRings.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/GroupRings.jl b/src/GroupRings.jl index 3c84198..0f51d70 100644 --- a/src/GroupRings.jl +++ b/src/GroupRings.jl @@ -1,3 +1,4 @@ +__precompile__() module GroupRings using Nemo