kalmar
/
GroupRings.jl
mirror of https://github.com/kalmarek/GroupRings.jl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

in mul! promote to the common type only if necessary

This commit is contained in:
kalmar 2017-07-12 11:34:43 +02:00
parent 4e213c691d
commit b40b9f94eb
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/GroupRings.jl
View File

@ -340,11 +340,14 @@ function mul!{T}(result::GroupRingElem{T}, X::GroupRingElem{T}, Y::GroupRingElem
end
function mul!(result::GroupRingElem, X::GroupRingElem, Y::GroupRingElem)
S, T, U = eltype(result), eltype(X), eltype(U)
S, T, U = eltype(result), eltype(X), eltype(Y)
TT = promote_type(S, T, U)
warn("Types $S, $T, $U are not the same, promoting the result to $TT")
if S != TT || T != TT || U != TT
warn("Types $S, $T, $U are not the same, promoting the result to $TT")
result.coeffs = convert(Array{TT},result.coeffs)
end
result = deepcopy(result)
mul!(convert(Array{TT},result.coeffs), convert(Array{TT}, X.coeffs), convert(Array{TT}, Y.coeffs), parent(X).pm)
mul!(result.coeffs, convert(Array{TT}, X.coeffs), convert(Array{TT}, Y.coeffs), parent(X).pm)
return result
end