From f6b270696ed2e6460168b6705bc0db304529a221 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Fri, 15 Mar 2019 08:05:14 +0100 Subject: [PATCH 1/3] stylistic changes to mul! --- src/GroupRings.jl | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/GroupRings.jl b/src/GroupRings.jl index 71e115f..46e7ee5 100644 --- a/src/GroupRings.jl +++ b/src/GroupRings.jl @@ -302,11 +302,11 @@ function mul(a::T, X::GroupRingElem{S}) where {T<:Number, S<:Number} return GroupRingElem(a.*X.coeffs, parent(X)) end -(*)(a::Number, X::GroupRingElem) = mul(a,X) -(*)(X::GroupRingElem, a::Number) = mul(a,X) +(*)(a::Number, X::GroupRingElem) = mul(a, X) +(*)(X::GroupRingElem, a::Number) = mul(a, X) # disallow Rings to hijack *(::, ::GroupRingElem) -*(a::Union{AbstractFloat, Integer, RingElem, Rational}, X::GroupRingElem) = mul(a,X) +*(a::Union{AbstractFloat, Integer, RingElem, Rational}, X::GroupRingElem) = mul(a, X) (/)(X::GroupRingElem, a) = 1/a*X (//)(X::GroupRingElem, a::Union{Integer, Rational}) = 1//a*X @@ -376,10 +376,8 @@ function fmac!(result::AbstractVector{T}, end @doc doc""" - GRmul!(result::AbstractVector{T}, - X::AbstractVector, - Y::AbstractVector, - pm::Array{Int,2}) where {T<:Number} + GRmul!(result::AbstractVector{T}, X::AbstractVector, Y::AbstractVector, + pm::Matrix{<:Integer}) where {T<:Number} > The most specialised multiplication for `X` and `Y` (intended for `coeffs` of > `GroupRingElems`), using multiplication table `pm`. > Notes: @@ -392,7 +390,7 @@ end function GRmul!(result::AbstractVector{T}, X::AbstractVector, Y::AbstractVector, - pm::Array{Int,2}) where {T<:Number} + pm::AbstractMatrix{<:Integer}) where {T<:Number} z = zero(T) result .= z @@ -400,9 +398,7 @@ function GRmul!(result::AbstractVector{T}, end @doc doc""" - mul!{T}(result::GroupRingElem{T}, - X::GroupRingElem, - Y::GroupRingElem) + mul!(result::GroupRingElem, X::GroupRingElem, Y::GroupRingElem) > In-place multiplication for `GroupRingElem`s `X` and `Y`. > `mul!` will make use the initialised entries of `pm` attribute of > `parent(X)::GroupRing` (if available), and will compute and store in `pm` the From d0d3a25524cc0cffb2b056e002270bd10a41dd98 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Fri, 15 Mar 2019 18:51:27 +0100 Subject: [PATCH 2/3] update travis & add badges --- .travis.yml | 7 +++---- README.md | 8 ++++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 28d4d10..608fbfc 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ os: - osx julia: - 1.0 + - 1.1 - nightly notifications: email: true @@ -14,8 +15,6 @@ matrix: - julia: nightly script: - - julia -e 'using Pkg; pkg"add https://github.com/kalmarek/Groups.jl#enh/julia-v0.7"; Pkg.build(); Pkg.test(coverage=true);' + - julia -e 'using Pkg; pkg"add https://github.com/kalmarek/Groups.jl"; Pkg.build(); Pkg.test(coverage=true);' -after_success: - # push coverage results to Coveralls - - julia -e 'import Pkg; Pkg.add("Coverage"); using Coverage; Codecov.submit(process_folder())' +codecov: true diff --git a/README.md b/README.md index 4f40151..91389a5 100644 --- a/README.md +++ b/README.md @@ -1 +1,9 @@ # GroupRings + +[![Build Status](https://travis-ci.org/kalmarek/GroupRings.jl.svg?branch=master)](https://travis-ci.org/kalmarek/GroupRings.jl) +[![codecov](https://codecov.io/gh/kalmarek/GroupRings.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/kalmarek/GroupRings.jl) + +Please have a look at [tests](https://github.com/kalmarek/GroupRings.jl/blob/master/test/runtests.jl) to see how to use this package. It depends on [AbstractAlgebra.jl](https://github.com/Nemocas/AbstractAlgebra.jl) and [Groups.jl](https://github.com/kalmarek/GroupRings.jl) + +For an example applications have a look at our papers: +[1703.09680](https://arxiv.org/abs/1703.09680), [1712.07167](https://arxiv.org/abs/1712.07167) and [1812.03456](https://arxiv.org/abs/1812.03456). From 632cf0a4d58b5a481274332031420645c8bda869 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Wed, 23 Oct 2019 09:17:45 +0200 Subject: [PATCH 3/3] fix link to Groups.jl --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 91389a5..29cf209 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ [![Build Status](https://travis-ci.org/kalmarek/GroupRings.jl.svg?branch=master)](https://travis-ci.org/kalmarek/GroupRings.jl) [![codecov](https://codecov.io/gh/kalmarek/GroupRings.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/kalmarek/GroupRings.jl) -Please have a look at [tests](https://github.com/kalmarek/GroupRings.jl/blob/master/test/runtests.jl) to see how to use this package. It depends on [AbstractAlgebra.jl](https://github.com/Nemocas/AbstractAlgebra.jl) and [Groups.jl](https://github.com/kalmarek/GroupRings.jl) +Please have a look at [tests](https://github.com/kalmarek/GroupRings.jl/blob/master/test/runtests.jl) to see how to use this package. It depends on [AbstractAlgebra.jl](https://github.com/Nemocas/AbstractAlgebra.jl) and [Groups.jl](https://github.com/kalmarek/Groups.jl) For an example applications have a look at our papers: [1703.09680](https://arxiv.org/abs/1703.09680), [1712.07167](https://arxiv.org/abs/1712.07167) and [1812.03456](https://arxiv.org/abs/1812.03456).