kalmar
/
GroupRings.jl
mirror of https://github.com/kalmarek/GroupRings.jl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

remove mul functions: * should call mul! directly

This commit is contained in:
kalmar 2017-07-19 22:41:15 +02:00
parent 5c2fabfb08
commit f586cb5146
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/GroupRings.jl
View File

@ -385,24 +385,7 @@ function mul(X::AbstractVector, Y::AbstractVector, pm::Array{Int,2})
return result
end
function *{T<:Number}(X::GroupRingElem{T}, Y::GroupRingElem{T})
parent(X) == parent(Y) || throw(ArgumentError(
"Elements don't seem to belong to the same Group Ring!"))
RG = parent(X)
isdefined(RG, :pm) || complete(RG)
result = mul(X.coeffs, Y.coeffs, RG.pm)
return GroupRingElem(result, RG)
end
function *{T<:Number, S<:Number}(X::GroupRingElem{T}, Y::GroupRingElem{S})
parent(X) == parent(Y) || throw("Elements don't seem to belong to the same
Group Ring!")
warn("Multiplying elements with different base rings!")
RG = parent(X)
isdefined(RG, :pm) || complete(RG)
result = mul(X.coeffs, Y.coeffs, RG.pm)
return GroupRingElem(result, RG)
end
function divexact{T}(X::GroupRingElem{T}, Y::GroupRingElem{T})
if length(Y) != 1