kalmar/GroupRings.jl
1
0
Fork 0
mirror of https://github.com/kalmarek/GroupRings.jl.git synced 2024-12-29 11:00:28 +01:00
Code Issues Releases Wiki Activity

don't compare bases when ==(::GroupRing, ::GroupRing)

Browse Source 
comparing pm should be enough
This commit is contained in:
kalmarek 2018-08-13 19:34:24 +02:00
parent 4dd2c02a4c
commit f6b31ec2c9
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/GroupRings.jl
View File

@ -250,22 +250,24 @@ end
############################################################################### ###############################################################################
function (==)(X::GroupRingElem, Y::GroupRingElem) function (==)(X::GroupRingElem, Y::GroupRingElem)
parent(X) == parent(Y) || return false
if eltype(X.coeffs) != eltype(Y.coeffs) if eltype(X.coeffs) != eltype(Y.coeffs)
warn("Comparing elements with different coeffs Rings!") warn("Comparing elements with different coeffs Rings!")
end end
all(X.coeffs .== Y.coeffs) || return false suppX = supp(X)
suppX == supp(Y) || return false
for g in suppX
X[g] == Y[g] || return false
end
return true return true
end end
function (==)(A::GroupRing, B::GroupRing) function (==)(A::GroupRing, B::GroupRing)
A.group == B.group || return false A.group == B.group || return false
if isdefined(A, :basis) && isdefined(B, :basis) complete!(A)
A.basis == B.basis || return false complete!(B)
else A.pm == B.pm || return false
baseless_warn && warn("Bases of GroupRings are not defined, comparing products mats.")
A.pm == B.pm || return false
end
return true return true
end end