From 22a8809c6fad1a3c4da789e71a65a7ced1f1f918 Mon Sep 17 00:00:00 2001
From: Marek Kaluba <kalmar@amu.edu.pl>
Date: Sat, 2 Apr 2022 14:53:06 +0200
Subject: [PATCH] rm AbstractAlgebra

---
 Project.toml          |  3 +--
 test/matrix_groups.jl | 18 ++++++++++++++----
 test/runtests.jl      | 14 --------------
 3 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/Project.toml b/Project.toml
index b7685fe..5d897ed 100644
--- a/Project.toml
+++ b/Project.toml
@@ -12,7 +12,6 @@ PermutationGroups = "8bc5a954-2dfc-11e9-10e6-cd969bffa420"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 
 [compat]
-AbstractAlgebra = "0.22"
 Folds = "0.2.7"
 GroupsCore = "0.4"
 KnuthBendix = "0.3"
@@ -27,4 +26,4 @@ PermutationGroups = "8bc5a954-2dfc-11e9-10e6-cd969bffa420"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Test", "BenchmarkTools", "AbstractAlgebra", "PermutationGroups"]
+test = ["Test", "BenchmarkTools"]
diff --git a/test/matrix_groups.jl b/test/matrix_groups.jl
index 853ab13..d047575 100644
--- a/test/matrix_groups.jl
+++ b/test/matrix_groups.jl
@@ -1,7 +1,6 @@
 using Groups.MatrixGroups
 
 @testset "Matrix Groups" begin
-
     @testset "SL(n, ℤ)" begin
         SL3Z = SpecialLinearGroup{3}(Int8)
 
@@ -9,7 +8,20 @@ using Groups.MatrixGroups
 
         E, sizes = Groups.wlmetric_ball(S, radius=4)
 
-        @test sizes = [13, 121, 883, 5455]
+        @test sizes == [13, 121, 883, 5455]
+
+        E(i,j) = SL3Z([A[MatrixGroups.ElementaryMatrix{3}(i,j, Int8(1))]])
+
+        A = alphabet(SL3Z)
+        w = E(1,2)
+        r = E(2,3)^-3
+        s = E(1,3)^2*E(3,2)^-1
+
+        S = [w,r,s]; S = unique([S; inv.(S)]);
+        _, sizes = Groups.wlmetric_ball(S, radius=4);
+        @test sizes == [7, 33, 141, 561]
+        _, sizes = Groups.wlmetric_ball_serial(S, radius=4);
+        @test sizes == [7, 33, 141, 561]
 
         @testset "GroupsCore conformance" begin
             test_Group_interface(SL3Z)
@@ -18,7 +30,5 @@ using Groups.MatrixGroups
 
             test_GroupElement_interface(g, h)
         end
-
     end
-
 end
diff --git a/test/runtests.jl b/test/runtests.jl
index 409f204..aeed59a 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -1,5 +1,4 @@
 using Test
-import AbstractAlgebra
 using Groups
 
 import KnuthBendix: Word
@@ -9,19 +8,6 @@ include(joinpath(pathof(GroupsCore), "..", "..", "test", "conformance_test.jl"))
 
 @testset "Groups" begin
 
-    @testset "wlmetric_ball" begin
-        M = AbstractAlgebra.MatrixAlgebra(AbstractAlgebra.zz, 3)
-        w = one(M); w[1,2] = 1;
-        r = one(M); r[2,3] = -3;
-        s = one(M); s[1,3] = 2; s[3,2] = -1;
-
-        S = [w,r,s]; S = unique([S; inv.(S)]);
-        _, sizes = Groups.wlmetric_ball(S, radius=4);
-        @test sizes == [7, 33, 141, 561]
-        _, sizes = Groups.wlmetric_ball_serial(S, radius=4);
-        @test sizes == [7, 33, 141, 561]
-    end
-
     include("free_groups.jl")
     include("fp_groups.jl")