From 29d1b8364d96e6efaac056e32dbdba36c43ce774 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Wed, 13 Sep 2017 15:43:56 +0200 Subject: [PATCH] fix deprecation warnings --- src/DirectProducts.jl | 2 +- src/WreathProducts.jl | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/DirectProducts.jl b/src/DirectProducts.jl index af26aee..fe9aefb 100644 --- a/src/DirectProducts.jl +++ b/src/DirectProducts.jl @@ -45,7 +45,7 @@ parent(g::DirectProductGroupElem) = ############################################################################### Base.size(g::DirectProductGroupElem) = size(g.elts) -Base.linearindexing(::Type{DirectProductGroupElem}) = Base.LinearFast() +Base.IndexStyle(::Type{DirectProductGroupElem}) = Base.LinearFast() Base.getindex(g::DirectProductGroupElem, i::Int) = g.elts[i] function Base.setindex!{T<:GroupElem}(g::DirectProductGroupElem{T}, v::T, i::Int) parent(v) == parent(first(g.elts)) || throw("$g is not an element of $i-th factor of $(parent(G))") diff --git a/src/WreathProducts.jl b/src/WreathProducts.jl index a490905..7a5ba83 100644 --- a/src/WreathProducts.jl +++ b/src/WreathProducts.jl @@ -23,7 +23,7 @@ immutable WreathProduct{T<:Group} <: Group N::DirectProductGroup{T} P::PermGroup - function WreathProduct(G::Group, P::PermGroup) + function WreathProduct{T}(G::T, P::PermGroup) where {T} N = DirectProductGroup(G, P.n) return new(N, P) end @@ -34,12 +34,12 @@ immutable WreathProductElem{T<:GroupElem} <: GroupElem p::perm # parent::WreathProduct - function WreathProductElem(n::DirectProductGroupElem, p::perm, - check::Bool=true) + function WreathProductElem{T}(n::DirectProductGroupElem{T}, p::perm, + check::Bool=true) where {T} if check length(n.elts) == parent(p).n || throw("Can't form WreathProductElem: lengths differ") end - return new(n, p) + return new{T}(n, p) end end @@ -62,10 +62,9 @@ parent(g::WreathProductElem) = WreathProduct(parent(g.n[1]), parent(g.p)) # ############################################################################### -WreathProduct{T<:Group}(G::T, P::PermGroup) = WreathProduct{T}(G, P) +WreathProduct(G::Gr, P::PermGroup) where {Gr} = WreathProduct{Gr}(G, P) -WreathProductElem{T<:GroupElem}(n::DirectProductGroupElem{T}, - p::perm, check::Bool=true) = WreathProductElem{T}(n, p, check) +WreathProductElem(n::DirectProductGroupElem{T}, p, check=true) where {T} = WreathProductElem{T}(n, p, check) ############################################################################### #