kalmar
/
Groups.jl
mirror of https://github.com/kalmarek/Groups.jl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

fix coercion to FPGroup

This commit is contained in:
kalmarek 2020-03-25 13:46:32 +01:00
parent 7d95338e33
commit 622f5bc6b3
No known key found for this signature in database
GPG Key ID: 8BF1A3855328FC15
1 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/FPGroups.jl
View File

@ -53,25 +53,20 @@ FPGroup(H::FreeGroup) = FPGroup([FPSymbol(s) for s in H.gens])
#
function (G::FPGroup)(w::GWord)
if isempty(w)
return one(G)
end
if isempty(w)
return one(G)
end
if eltype(w.symbols) == FreeSymbol
w = FPGroupElem(FPSymbol.(w.symbols))
end
@boundscheck for s in syllables(w)
i = findfirst(g -> g.id == s.id, G.gens)
i == 0 && throw(DomainError("Symbol $s does not belong to $G."))
s.pow % G.gens[i].pow != 0 && throw(
DomainError("Symbol $s doesn't belong to $G."))
end
if eltype(w.symbols) == FPSymbol
for s in w.symbols
i = findfirst(g -> g.id == s.id, G.gens)
i == 0 && throw(DomainError(
"Symbol $s does not belong to $G."))
s.pow % G.gens[i].pow == 0 || throw(DomainError(
"Symbol $s doesn't belong to $G."))
end
end
w.parent = G
return reduce!(w)
w = FPGroupElem(FPSymbol.(syllables(w)))
setparent!(w, G)
return reduce!(w)
end
(G::FPGroup)(s::GSymbol) = G(FPGroupElem(s))