kalmar/Groups.jl
1
0
Fork 0
mirror of https://github.com/kalmarek/Groups.jl.git synced 2024-12-24 01:55:29 +01:00
Code Issues Releases Wiki Activity

more economical generate_balls using Base.product

Browse Source
This commit is contained in:
kalmarek 2017-11-05 14:58:58 +01:00
parent d6befc7990
commit 78881e1d79
1 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/Groups.jl
View File

@ -378,28 +378,12 @@ end
#
###############################################################################
function products{T<:GroupElem}(X::AbstractVector{T}, Y::AbstractVector{T}, op=*)
result = Vector{T}()
seen = Set{T}()
for x in X
for y in Y
z = op(x,y)
if !in(z, seen)
push!(seen, z)
push!(result, z)
end
end
end
return result
end
function generate_balls{T<:GroupElem}(S::Vector{T}, Id::T; radius=2, op=*)
sizes = Vector{Int}()
S = deepcopy(S)
S = unshift!(S, Id)
function generate_balls{T<:GroupElem}(S::Vector{T}, Id::T=parent(first(S))(); radius=2, op=*)
sizes = Int[]
B = [Id]
for i in 1:radius
B = products(B, S, op);
BB = [op(i,j) for (i,j) in Base.product(B,S)]
B = unique([B; vec(BB)])
push!(sizes, length(B))
end
return B, sizes