From fe0e22f0bf39f3c367b0d36527e65eb3affdea83 Mon Sep 17 00:00:00 2001
From: kalmarek <kalmar@amu.edu.pl>
Date: Mon, 30 Jul 2018 13:54:15 +0200
Subject: [PATCH] align to perms acting on the right

---
 src/AutGroup.jl       |  2 +-
 src/WreathProducts.jl | 11 ++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/AutGroup.jl b/src/AutGroup.jl
index 5c9952a..722dec4 100644
--- a/src/AutGroup.jl
+++ b/src/AutGroup.jl
@@ -384,6 +384,6 @@ function matrix_repr(a::FlipAut, n::Int, pow)
     return x
 end
 
-matrix_repr(a::PermAut, n::Int, pow) = eye(n)[:, (a.perm^pow).d]
+matrix_repr(a::PermAut, n::Int, pow) = eye(n)[(a.perm^pow).d, :]
 
 matrix_repr(a::Identity, n::Int, pow) = eye(n)
diff --git a/src/WreathProducts.jl b/src/WreathProducts.jl
index 629fae4..e4f3490 100644
--- a/src/WreathProducts.jl
+++ b/src/WreathProducts.jl
@@ -37,7 +37,7 @@ struct WreathProductElem{T<:GroupElem, I<:Integer} <: GroupElem
    function WreathProductElem{T, I}(n::DirectProductGroupElem{T}, p::Generic.perm{I},
       check::Bool=true) where {T, I}
       if check
-         length(n.elts) == parent(p).n || throw("Can't form WreathProductElem: lengths differ")
+         length(n.elts) == length(p) || throw("Can't form WreathProductElem: lengths differ")
       end
       return new(n, p)
    end
@@ -164,6 +164,8 @@ end
 #
 ###############################################################################
 
+(p::perm)(n::DirectProductGroupElem) = DirectProductGroupElem(n.elts[p.d])
+
 doc"""
     *(g::WreathProductElem, h::WreathProductElem)
 > Return the wreath product group operation of elements, i.e.
@@ -174,8 +176,7 @@ doc"""
 > `h.n::DirectProductGroupElem` via standard permutation of coordinates.
 """
 function *(g::WreathProductElem, h::WreathProductElem)
-   w = DirectProductGroupElem((h.n).elts[inv(g.p).d])
-   return WreathProductElem(g.n*w, g.p*h.p, false)
+   return WreathProductElem(g.n*g.p(h.n), g.p*h.p, false)
 end
 
 doc"""
@@ -184,8 +185,8 @@ doc"""
 >   `g^-1 = (g.n, g.p)^-1 = (g.p^-1(g.n^-1), g.p^-1)`.
 """
 function inv(g::WreathProductElem)
-   w = DirectProductGroupElem(inv(g.n).elts[g.p.d])
-   return WreathProductElem(w, inv(g.p), false)
+   pinv = inv(g.p)
+   return WreathProductElem(pinv(inv(g.n)), pinv, false)
 end
 
 ###############################################################################