fine-tune orthSVD

2017-06-21 16:44:14 +02:00 · 2017-06-21 16:44:14 +02:00 · d2e2862ae6
commit d2e2862ae6
parent cc0f07bfd2
1 changed files with 3 additions and 4 deletions
--- a/OrbitDecomposition.jl
+++ b/OrbitDecomposition.jl
@ -128,10 +128,9 @@ end
 function orthSVD(M::AbstractMatrix)
    M = full(M)
    fact = svdfact(M)
-    sings = fact[:S]
-    M_rank = sum(fact[:S] .> maximum(size(M))*eps(eltype(fact[:S])))
-    Ufactor = fact[:U]
-    return Ufactor[:,1:M_rank]
+    singv = fact[:S]
+    M_rank = sum(singv .> maximum(size(M))*eps(eltype(singv)))
+    return fact[:U][:,1:M_rank]
 end

 function Uπ_matrices(P_matrices; orth=orthSVD)