From 2d02c98947f12f47cfcd28371323a83d763778b5 Mon Sep 17 00:00:00 2001
From: kalmarek <kalmar@amu.edu.pl>
Date: Wed, 8 Nov 2017 09:29:12 +0100
Subject: [PATCH] faster & simpler Cstar_repr

---
 src/OrbitDecomposition.jl | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/OrbitDecomposition.jl b/src/OrbitDecomposition.jl
index 51f14fa..64ef886 100644
--- a/src/OrbitDecomposition.jl
+++ b/src/OrbitDecomposition.jl
@@ -187,15 +187,7 @@ function reconstruct_sol{T<:GroupElem, S<:Nemo.perm}(preps::Dict{T, S},
 end
 
 function Cstar_repr{T}(x::GroupRingElem{T}, mreps::Dict)
-   res = spzeros(size(mreps[first(keys(mreps))])...)
-
-   for g in parent(x).basis
-      if x[g] != zero(T)
-         res .+= Float64(x[g]).*mreps[g]
-      end
-   end
-
-   return res
+   return sum(x[g].*mreps[g] for g in parent(x).basis if x[g] != zero(T))
 end
 
 function orthSVD(M::AbstractMatrix)