1
0
mirror of https://github.com/kalmarek/PropertyT.jl.git synced 2024-12-25 10:20:30 +01:00

streamline logic in rankOne_projection from a character

This commit is contained in:
kalmarek 2018-04-08 22:49:45 +02:00
parent 5bed58de2c
commit 50588bc792

View File

@ -102,8 +102,7 @@ function idempotents(RG::GroupRing{Generic.PermGroup{S}}, T::Type=Rational{S}) w
return unique(idems)
end
function rankOne_projection(chi::PropertyT.PermCharacter,
idems::Vector{T}) where {T<:GroupRingElem}
function rankOne_projection(chi::PermCharacter, idems::Vector{T}) where {T<:GroupRingElem}
RG = parent(first(idems))
S = eltype(first(idems))
@ -114,12 +113,14 @@ function rankOne_projection(chi::PropertyT.PermCharacter,
for (i,j,k) in Base.product(ids, ids, ids)
if chi(i) == zzz || chi(j) == zzz || chi(k) == zzz
continue
end
elt = i*j*k
elt^2 == elt || continue
if chi(elt) == one(S)
return elt
# return (i,j,k)
else
elt = i*j*k
if elt^2 != elt
continue
elseif chi(elt) == one(S)
return elt
# return (i,j,k)
end
end
end
throw("Couldn't find rank-one projection for $chi")