From 94c9a75a2187495ce65adda5e63a09a11da0da7d Mon Sep 17 00:00:00 2001 From: kalmarek Date: Fri, 27 Oct 2017 14:29:47 +0200 Subject: [PATCH] we don't need to pass id element -- it could be derived from S --- src/SDPs.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/SDPs.jl b/src/SDPs.jl index b2a9fa5..7a41479 100644 --- a/src/SDPs.jl +++ b/src/SDPs.jl @@ -13,18 +13,18 @@ function constraints_from_pm(pm, total_length=maximum(pm)) return constraints end -function splaplacian{TT<:Group}(RG::GroupRing{TT}, S, Id=RG.group(), T::Type=Float64) +function splaplacian(RG::GroupRing, S, T::Type=Float64) result = RG(T) - result[Id] = T(length(S)) + result[RG.group()] = T(length(S)) for s in S result[s] -= one(T) end return result end -function splaplacian{TT<:Ring}(RG::GroupRing{TT}, S, Id=one(RG.group), T::Type=Float64) +function splaplacian{TT<:Ring}(RG::GroupRing{TT}, S, T::Type=Float64) result = RG(T) - result[Id] = T(length(S)) + result[one(RG.group)] = T(length(S)) for s in S result[s] -= one(T) end