From ac4ef92ef04ace635e3003e48f50baccee518e43 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Tue, 2 Jan 2018 03:28:34 +0100 Subject: [PATCH] no need to pass both Group and S as arguments --- src/Orbit-wise.jl | 2 +- src/OrbitDecomposition.jl | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Orbit-wise.jl b/src/Orbit-wise.jl index f300cda..cc34a3c 100644 --- a/src/Orbit-wise.jl +++ b/src/Orbit-wise.jl @@ -222,7 +222,7 @@ function check_property_T(sett::Settings) files_exists = ex.([:pm, :Δ, :Uπs, :orb, :preps]) if !all(files_exists) - compute_orbit_data(sett.logger, prepath(sett), sett.G, sett.S, sett.autS, radius=sett.radius) + compute_orbit_data(sett.logger, prepath(sett), sett.S, sett.autS, radius=sett.radius) end cond1 = exists(filename(fullpath(sett), :λ)) diff --git a/src/OrbitDecomposition.jl b/src/OrbitDecomposition.jl index 2ad2e96..1b69e28 100644 --- a/src/OrbitDecomposition.jl +++ b/src/OrbitDecomposition.jl @@ -166,12 +166,13 @@ function orthSVD{T}(M::AbstractMatrix{T}) return fact[:U][:,1:M_rank] end -function compute_orbit_data{T<:GroupElem}(logger, name::String, G::Nemo.Group, S::Vector{T}, autS::Nemo.Group; radius=2) +function compute_orbit_data{T<:GroupElem}(logger, name::String, S::Vector{T}, autS::Nemo.Group; radius=2) isdir(name) || mkdir(name) info(logger, "Generating ball of radius $(2*radius)") # TODO: Fix that by multiple dispatch? + G = parent(first(S)) Id = (isa(G, Nemo.Ring) ? one(G) : G()) @logtime logger E_2R, sizes = Groups.generate_balls(S, Id, radius=2*radius);