From fbb00084575370005068d3be1e11328ac94d0877 Mon Sep 17 00:00:00 2001
From: Marek Kaluba <kalmar@amu.edu.pl>
Date: Mon, 17 Jan 2022 20:31:26 +0100
Subject: [PATCH] split parse_magma_fpgroup to get gens/rels as strings

---
 src/groupparse.jl | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/groupparse.jl b/src/groupparse.jl
index 09d6460..c849c7c 100644
--- a/src/groupparse.jl
+++ b/src/groupparse.jl
@@ -6,13 +6,15 @@ const COMMUTATOR_regex = r"\((?<comm>[\w](\s?,\s?[\w]){1+})\)"
 iscomment(line) = startswith(line, "//")
 ismagma_presentation(line) = (m = match(MAGMA_PRESENTATION_regex, line); return !isnothing(m), m)
 
-function parse_magma_fpgroup(str::AbstractString)
+
+
+function split_magma_presentation(str::AbstractString)
     m = match(MAGMA_PRESENTATION_regex, str)
     gens_str = strip.(split(m[:gens], ","))
     rels_str = m[:rels]
     split_indices = [0]
-    in_function_call=0
-    for (i,s) in enumerate(rels_str)
+    in_function_call = 0
+    for (i, s) in enumerate(rels_str)
         if s == '('
             in_function_call += 1
         elseif s == ')'
@@ -23,13 +25,20 @@ function parse_magma_fpgroup(str::AbstractString)
         end
     end
     @assert in_function_call == 0
-    push!(split_indices, length(rels_str)+1)
+    push!(split_indices, length(rels_str) + 1)
 
-    rels_strs = [strip.(String(rels_str[s+1:e-1])) for (s,e) in zip(split_indices, Iterators.rest(split_indices, 2))]
+    rels_strs = [
+        strip.(String(rels_str[s+1:e-1])) for
+        (s, e) in zip(split_indices, Iterators.rest(split_indices, 2))
+    ]
 
     # rels_strs = replace.(rels_strs, COMMUTATOR_regex=> s"comm(\g<comm>)")
     # @show rels_strs
+    return gens_str, rels_strs
+end
 
+function parse_magma_fpgroup(str::AbstractString)
+    gens_str, rels_strs = split_magma_presentation(str)
     return parse_magma_fpgroup(gens_str, rels_strs)
 end