s416496/musique
1
0
Fork 0
Code Issues 3 Pull Requests 1 Projects Releases Wiki Activity

Better error reporting of not mached parens

Browse Source
This commit is contained in:
Robert Bendun 2022-06-20 13:21:37 +02:00
parent 21bf18bbdd
commit 772686a2fc
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/errors.cc
View File

@ -185,8 +185,10 @@ std::ostream& operator<<(std::ostream& os, Error const& err)
Lines::the.print(os, std::string(loc->filename), loc->line, loc->line);
os << pretty::begin_comment << "\nThis error is considered an internal one. It should not be displayed to the end user.\n" << pretty::end;
encourage_contact(os);
os << pretty::begin_comment << "\nThis error is considered an internal one. It should not be displayed to the end user.\n";
os << "\n";
os << "This error message is temporary and will be replaced by better one in the future\n";
os << pretty::end;
},
[&](errors::Expected_Expression_Separator_Before const& err) {

15
src/parser.cc
View File

@ -271,7 +271,10 @@ Result<Ast> Parser::parse_atomic_expression()
}
}
}
unimplemented("Don't know why it stopped, maybe end of file?");
return Error {
.details = errors::Unexpected_Empty_Source {},
.location = {}
};
}
consume();
if (is_lambda) {
@ -287,7 +290,15 @@ Result<Ast> Parser::parse_atomic_expression()
consume();
auto ast = Try(parse_sequence());
if (not expect(Token::Type::Close_Paren)) {
unimplemented("Error handling of this code is not implemented yet");
auto const& token = Try(peek());
return Error {
.details = errors::internal::Unexpected_Token {
.type = type_name(token.type),
.source = token.source,
.when = "waiting for closing paren ')'"
},
.location = token.location
};
}
consume();
return ast;