From 000be9a7831efa5c95493b33562c451249260bc6 Mon Sep 17 00:00:00 2001 From: TonyO Date: Mon, 26 Mar 2018 17:33:26 -0500 Subject: [PATCH] removed unused code from Java classes --- .../refine/exporters/sql/SqlCreateBuilder.java | 16 ++++++---------- .../google/refine/exporters/sql/SqlExporter.java | 4 +++- .../refine/exporters/sql/SqlInsertBuilder.java | 7 ++++--- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java b/main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java index ba0ffdadf..416b26e30 100755 --- a/main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java +++ b/main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java @@ -44,7 +44,7 @@ public class SqlCreateBuilder { private String table; - @SuppressWarnings("unused") + private List columns; private JSONObject options; @@ -56,13 +56,15 @@ public class SqlCreateBuilder { } public String getCreateSQL() { + if(logger.isDebugEnabled()) { + logger.debug("Create SQL with columns: {}", columns); + } StringBuffer createSB = new StringBuffer(); JSONArray columnOptionArray = options == null ? null : JSONUtilities.getArray(options, "columns"); final boolean trimColNames = options == null ? false : JSONUtilities.getBoolean(options, "trimColumnNames", false); - - //logger.info("Trim Column Names::" + trimColNames); + int count = columnOptionArray.length(); for (int i = 0; i < count; i++) { @@ -138,12 +140,6 @@ public class SqlCreateBuilder { return createSQL; } -// public static void main(String[] args) { -// String column = "Column 1 With Spaces"; -// String newCol = column.replaceAll("\\s", ""); -// -// logger.info("Column after trim:" + newCol); -// -// } + } diff --git a/main/src/com/google/refine/exporters/sql/SqlExporter.java b/main/src/com/google/refine/exporters/sql/SqlExporter.java index 67fa176aa..d0629763d 100755 --- a/main/src/com/google/refine/exporters/sql/SqlExporter.java +++ b/main/src/com/google/refine/exporters/sql/SqlExporter.java @@ -66,7 +66,9 @@ public class SqlExporter implements WriterExporter { @Override public void export(final Project project, Properties params, Engine engine, final Writer writer) throws IOException { - + if(logger.isDebugEnabled()) { + logger.debug("export sql with params: {}", params); + } TabularSerializer serializer = new TabularSerializer() { @Override diff --git a/main/src/com/google/refine/exporters/sql/SqlInsertBuilder.java b/main/src/com/google/refine/exporters/sql/SqlInsertBuilder.java index 97fea4077..9c60334d9 100755 --- a/main/src/com/google/refine/exporters/sql/SqlInsertBuilder.java +++ b/main/src/com/google/refine/exporters/sql/SqlInsertBuilder.java @@ -73,7 +73,9 @@ public class SqlInsertBuilder { * @return */ public String getInsertSQL() { - // logger.info("options values::::{}", options); + if(logger.isDebugEnabled()) { + logger.debug("Insert SQL with columns: {}", columns); + } JSONArray columnOptionArray = options == null ? null : JSONUtilities.getArray(options, "columns"); //logger.info("columnOptionArray::::{}", columnOptionArray); @@ -130,8 +132,7 @@ public class SqlInsertBuilder { values.append(","); } values.append("\n"); -// logger.info("running values:{}", values.toString()); - + }