From 02b0c405589a58f84d16bbf9c888dde9c4919c53 Mon Sep 17 00:00:00 2001
From: David Huynh <dfhuynh@gmail.com>
Date: Fri, 5 Feb 2010 23:24:52 +0000
Subject: [PATCH] Polished popup menus: popouts are positioned better to show
 the right arrows, expanded sub-menus are persistently highlighted in gray.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@52 7d457c2a-affb-35e4-300a-418c747d4874
---
 src/main/webapp/scripts/util/menu.js | 27 +++++++++++++++++++++------
 src/main/webapp/styles/common.css    |  4 ++++
 2 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/src/main/webapp/scripts/util/menu.js b/src/main/webapp/scripts/util/menu.js
index 8991cd87a..30451f000 100644
--- a/src/main/webapp/scripts/util/menu.js
+++ b/src/main/webapp/scripts/util/menu.js
@@ -3,7 +3,7 @@ MenuSystem = {
     _overlay: null
 };
 
-MenuSystem.showMenu = function(elmt) {
+MenuSystem.showMenu = function(elmt, onDismiss) {
     if (MenuSystem._overlay == null) {
         MenuSystem._overlay = $('<div>&nbsp;</div>')
             .addClass("menu-overlay")
@@ -15,7 +15,8 @@ MenuSystem.showMenu = function(elmt) {
     elmt.css("z-index", 1001 + MenuSystem._layers.length).appendTo(document.body);
     
     var layer = {
-        elmt: elmt
+        elmt: elmt,
+        onDismiss: onDismiss
     };
     MenuSystem._layers.push(layer);
     
@@ -36,7 +37,9 @@ MenuSystem.dismissAll = function() {
 
 MenuSystem.dismissUntil = function(level) {
     for (var i = MenuSystem._layers.length - 1; i >= level; i--) {
-        MenuSystem._layers[i].elmt.remove();
+        var layer = MenuSystem._layers[i];
+        layer.elmt.remove();
+        layer["onDismiss"]();
     }
     MenuSystem._layers = MenuSystem._layers.slice(0, level);
 };
@@ -58,7 +61,7 @@ MenuSystem.positionMenuAboveBelow = function(menu, elmt) {
 MenuSystem.positionMenuLeftRight = function(menu, elmt) {
     var offset = elmt.offset();
     menu.css("top", offset.top + "px")
-        .css("left", (offset.left + elmt.width()) + "px");
+        .css("left", (offset.left + elmt.width() + 10) + "px");
 };
 
 MenuSystem.createAndShowStandardMenu = function(items, elmt, options) {
@@ -78,7 +81,19 @@ MenuSystem.createAndShowStandardMenu = function(items, elmt, options) {
                 menuItem.html('<table width="100%" cellspacing="0" cellpadding="0"><tr><td>' + item.label + '</td><td width="1%"><img src="/images/right-arrow.png" /></td></tr></table>');
                 menuItem.mouseover(function() {
                     MenuSystem.dismissUntil(level);
-                    MenuSystem.createAndShowStandardMenu(item.submenu, this, { horizontal: true });
+                    
+                    menuItem.addClass("menu-expanded");
+                    
+                    MenuSystem.createAndShowStandardMenu(
+                        item.submenu, 
+                        this,
+                        {
+                            horizontal: true,
+                            onDismiss: function() {
+                                menuItem.removeClass("menu-expanded");
+                            }
+                        }
+                    );
                 });
             } else {
                 menuItem.html(item.label).click(item.click);
@@ -100,7 +115,7 @@ MenuSystem.createAndShowStandardMenu = function(items, elmt, options) {
         createMenuItem(items[i]);
     }
     
-    var level = MenuSystem.showMenu(menu);
+    var level = MenuSystem.showMenu(menu, "onDismiss" in options ? options.onDismiss : function(){});
     if (options.horizontal) {
         MenuSystem.positionMenuLeftRight(menu, $(elmt));
     } else {
diff --git a/src/main/webapp/styles/common.css b/src/main/webapp/styles/common.css
index cdf477fd4..c0cb9aaad 100644
--- a/src/main/webapp/styles/common.css
+++ b/src/main/webapp/styles/common.css
@@ -86,6 +86,10 @@ a.menu-item:hover {
     background: #eee;
 }
 
+a.menu-item.menu-expanded {
+    background: #ddd;
+}
+
 a.menu-item img {
     border: none;
 }