From 07945f9cde14c23635fc698bcfca843b094f9a0e Mon Sep 17 00:00:00 2001 From: David Huynh Date: Wed, 17 Mar 2010 21:43:58 +0000 Subject: [PATCH] A more helpful error message when the excel importer fails. git-svn-id: http://google-refine.googlecode.com/svn/trunk@313 7d457c2a-affb-35e4-300a-418c747d4874 --- .../metaweb/gridworks/importers/ExcelImporter.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/metaweb/gridworks/importers/ExcelImporter.java b/src/main/java/com/metaweb/gridworks/importers/ExcelImporter.java index c417e0146..435d353ab 100644 --- a/src/main/java/com/metaweb/gridworks/importers/ExcelImporter.java +++ b/src/main/java/com/metaweb/gridworks/importers/ExcelImporter.java @@ -1,5 +1,6 @@ package com.metaweb.gridworks.importers; +import java.io.IOException; import java.io.InputStream; import java.io.Reader; import java.io.Serializable; @@ -39,10 +40,19 @@ public class ExcelImporter implements Importer { public void read(InputStream inputStream, Project project, Properties options, int skip, int limit) throws Exception { - Workbook wb = _xmlBased ? + Workbook wb = null; + try { + wb = _xmlBased ? new XSSFWorkbook(inputStream) : new HSSFWorkbook(new POIFSFileSystem(inputStream)); - + } catch (IOException e) { + throw new IOException( + "Attempted to parse file as Excel file but failed. " + + "Try to use Excel to re-save the file as a different Excel version or as TSV and upload again.", + e + ); + } + Sheet sheet = wb.getSheetAt(0); int firstRow = sheet.getFirstRowNum();