Delay constructing the candidates array in recon objects to save memory.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@124 7d457c2a-affb-35e4-300a-418c747d4874

src/main/java/com/metaweb/gridworks/model/Recon.java

@@ -1,8 +1,8 @@
 package com.metaweb.gridworks.model;
 
 import java.io.Serializable;
+import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
@@ -12,7 +12,7 @@ import org.json.JSONWriter;
 
 import com.metaweb.gridworks.Jsonizable;
 import com.metaweb.gridworks.expr.HasFields;
-
+ 
 public class Recon implements Serializable, HasFields, Jsonizable {
 	private static final long serialVersionUID = 8906257833709315762L;
 	
@@ -60,7 +60,7 @@ public class Recon implements Serializable, HasFields, Jsonizable {
 	
 	final public long			id;
 	public Object[] 			features = new Object[Feature_max];
-	public List<ReconCandidate> candidates = new LinkedList<ReconCandidate>();
+	public List<ReconCandidate> candidates;
 	public Judgment				judgment = Judgment.None;
 	public ReconCandidate		match = null;
 	
@@ -79,6 +79,20 @@ public class Recon implements Serializable, HasFields, Jsonizable {
 		return r;
 	}
 	
+	public void addCandidate(ReconCandidate candidate) {
+		if (candidates == null) {
+			candidates = new ArrayList<ReconCandidate>(3);
+		}
+		candidates.add(candidate);
+	}
+	
+	public ReconCandidate getBestCandidate() {
+		if (candidates != null && candidates.size() > 0) {
+			return candidates.get(0);
+		}
+		return null;
+	}
+	
 	public Object getFeature(int feature) {
 		return feature < features.length ? features[feature] : null;
 	}
@@ -104,7 +118,7 @@ public class Recon implements Serializable, HasFields, Jsonizable {
 	
 	public Object getField(String name, Properties bindings) {
 		if ("best".equals(name)) {
-			return candidates.size() > 0 ? candidates.get(0) : null;
+			return candidates != null && candidates.size() > 0 ? candidates.get(0) : null;
 		} else if ("judgment".equals(name) || "judgement".equals(name)) {
 			return judgmentToString();
 		} else if ("matched".equals(name)) {
@@ -142,8 +156,10 @@ public class Recon implements Serializable, HasFields, Jsonizable {
 			match.write(writer, options);
 		} else {
 			writer.key("c"); writer.array();
-			for (ReconCandidate c : candidates) {
+			if (candidates != null) {
-				c.write(writer, options);
+				for (ReconCandidate c : candidates) {
+					c.write(writer, options);
+				}
 			}
 			writer.endArray();
 		}

src/main/java/com/metaweb/gridworks/operations/ReconMatchBestCandidatesOperation.java

@@ -12,6 +12,7 @@ import com.metaweb.gridworks.model.AbstractOperation;
 import com.metaweb.gridworks.model.Cell;
 import com.metaweb.gridworks.model.Column;
 import com.metaweb.gridworks.model.Project;
+import com.metaweb.gridworks.model.ReconCandidate;
 import com.metaweb.gridworks.model.Row;
 import com.metaweb.gridworks.model.Recon.Judgment;
 import com.metaweb.gridworks.model.changes.CellChange;
@@ -71,16 +72,19 @@ public class ReconMatchBestCandidatesOperation extends EngineDependentMassCellOp
 			public boolean visit(Project project, int rowIndex, Row row, boolean contextual) {
 				if (cellIndex < row.cells.size()) {
 					Cell cell = row.cells.get(cellIndex);
-					if (cell.recon != null && cell.recon.candidates.size() > 0) {
+					if (cell.recon != null) {
-						Cell newCell = new Cell(
+						ReconCandidate candidate = cell.recon.getBestCandidate();
-							cell.value,
+						if (candidate != null) {
-							cell.recon.dup()
+							Cell newCell = new Cell(
-						);
+								cell.value,
-						newCell.recon.match = newCell.recon.candidates.get(0);
+								cell.recon.dup()
-						newCell.recon.judgment = Judgment.Matched;
+							);
-						
+							newCell.recon.match = candidate;
-						CellChange cellChange = new CellChange(rowIndex, cellIndex, cell, newCell);
+							newCell.recon.judgment = Judgment.Matched;
-						cellChanges.add(cellChange);
+							
+							CellChange cellChange = new CellChange(rowIndex, cellIndex, cell, newCell);
+							cellChanges.add(cellChange);
+						}
 					}
 				}
 				return false;

src/main/java/com/metaweb/gridworks/operations/ReconOperation.java

@@ -362,7 +362,8 @@ public class ReconOperation extends EngineDependentOperation {
 			Recon recon = new Recon();
 			try {
 				int length = results.length();
-				for (int i = 0; i < length && recon.candidates.size() < 3; i++) {
+				int count = 0;
+				for (int i = 0; i < length && count < 3; i++) {
 					JSONObject result = results.getJSONObject(i);
 					if (!result.has("name")) {
 						continue;
@@ -402,7 +403,8 @@ public class ReconOperation extends EngineDependentOperation {
 						}
 					}
 					
-					recon.candidates.add(candidate);
+					recon.addCandidate(candidate);
+					count++;
 				}
 			} catch (JSONException e) {
 				e.printStackTrace();