Range check column move. Delete dead code. Fixes #602

main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js

@@ -70,15 +70,6 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
         }
       );
     });
-
-    var o = DataTableView.sampleVisibleRows(column);
-    var previewWidget = new ExpressionPreviewDialog.Widget(
-      elmts, 
-      column.cellIndex,
-      o.rowIndices,
-      o.values,
-      null
-    );
   };
 
   var doAddColumnByFetchingURLs = function() {
@@ -115,15 +106,6 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
       );
       dismiss();
     });
-
-    var o = DataTableView.sampleVisibleRows(column);
-    var previewWidget = new ExpressionPreviewDialog.Widget(
-      elmts, 
-      column.cellIndex,
-      o.rowIndices,
-      o.values,
-      null
-    );
   };
 
   var doRemoveColumn = function() {
@@ -165,15 +147,18 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
   };
 
   var doMoveColumnBy = function(change) {
-    Refine.postCoreProcess(
+    var newidx = Refine.columnNameToColumnIndex(column.name) + change;
-      "move-column", 
+    if (newidx > 0 && newidx < Refine.columnNameToColumnIndex(column.name)) {
-      {
+      Refine.postCoreProcess(
-        columnName: column.name,
+          "move-column", 
-        index: Refine.columnNameToColumnIndex(column.name) + change
+          {
-      },
+            columnName: column.name,
-      null,
+            index: newidx
-      { modelsChanged: true }
+          },
-    );
+          null,
+          { modelsChanged: true }
+      );
+    }
   };
 
   var doSplitColumn = function() {