Range check column move. Delete dead code. Fixes #602
This commit is contained in:
parent
0cb0269ae8
commit
109138366b
@ -70,15 +70,6 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
|
||||
}
|
||||
);
|
||||
});
|
||||
|
||||
var o = DataTableView.sampleVisibleRows(column);
|
||||
var previewWidget = new ExpressionPreviewDialog.Widget(
|
||||
elmts,
|
||||
column.cellIndex,
|
||||
o.rowIndices,
|
||||
o.values,
|
||||
null
|
||||
);
|
||||
};
|
||||
|
||||
var doAddColumnByFetchingURLs = function() {
|
||||
@ -115,15 +106,6 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
|
||||
);
|
||||
dismiss();
|
||||
});
|
||||
|
||||
var o = DataTableView.sampleVisibleRows(column);
|
||||
var previewWidget = new ExpressionPreviewDialog.Widget(
|
||||
elmts,
|
||||
column.cellIndex,
|
||||
o.rowIndices,
|
||||
o.values,
|
||||
null
|
||||
);
|
||||
};
|
||||
|
||||
var doRemoveColumn = function() {
|
||||
@ -165,15 +147,18 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
|
||||
};
|
||||
|
||||
var doMoveColumnBy = function(change) {
|
||||
var newidx = Refine.columnNameToColumnIndex(column.name) + change;
|
||||
if (newidx > 0 && newidx < Refine.columnNameToColumnIndex(column.name)) {
|
||||
Refine.postCoreProcess(
|
||||
"move-column",
|
||||
{
|
||||
columnName: column.name,
|
||||
index: Refine.columnNameToColumnIndex(column.name) + change
|
||||
index: newidx
|
||||
},
|
||||
null,
|
||||
{ modelsChanged: true }
|
||||
);
|
||||
}
|
||||
};
|
||||
|
||||
var doSplitColumn = function() {
|
||||
|
Loading…
Reference in New Issue
Block a user