Fix Codacy issues

This commit is contained in:
Antonin Delpeuch 2017-08-03 12:47:09 +01:00
parent 7de2a57c3a
commit 135dd50413

View File

@ -53,23 +53,15 @@ import org.testng.annotations.Test;
import com.google.refine.ProjectManager; import com.google.refine.ProjectManager;
import com.google.refine.ProjectMetadata; import com.google.refine.ProjectMetadata;
import com.google.refine.browsing.RowVisitor;
import com.google.refine.history.HistoryEntry;
import com.google.refine.grel.Function;
import com.google.refine.RefineServlet; import com.google.refine.RefineServlet;
import com.google.refine.importers.SeparatorBasedImporter; import com.google.refine.importers.SeparatorBasedImporter;
import com.google.refine.importing.ImportingJob; import com.google.refine.importing.ImportingJob;
import com.google.refine.importing.ImportingManager; import com.google.refine.importing.ImportingManager;
import com.google.refine.io.FileProjectManager; import com.google.refine.io.FileProjectManager;
import com.google.refine.model.AbstractOperation; import com.google.refine.model.AbstractOperation;
import com.google.refine.model.Cell;
import com.google.refine.model.Column;
import com.google.refine.model.ModelException; import com.google.refine.model.ModelException;
import com.google.refine.model.Project; import com.google.refine.model.Project;
import com.google.refine.model.Row;
import com.google.refine.process.Process; import com.google.refine.process.Process;
import com.google.refine.process.ProcessManager;
import com.google.refine.operations.OnError;
import com.google.refine.operations.cell.KeyValueColumnizeOperation; import com.google.refine.operations.cell.KeyValueColumnizeOperation;
import com.google.refine.tests.RefineServletStub; import com.google.refine.tests.RefineServletStub;
import com.google.refine.tests.RefineTest; import com.google.refine.tests.RefineTest;
@ -77,6 +69,14 @@ import com.google.refine.tests.util.TestUtils;
public class KeyValueColumnizeTests extends RefineTest { public class KeyValueColumnizeTests extends RefineTest {
// dependencies
private RefineServlet servlet;
private Project project;
private ProjectMetadata pm;
private JSONObject options;
private ImportingJob job;
private SeparatorBasedImporter importer;
@Override @Override
@BeforeTest @BeforeTest
@ -84,14 +84,6 @@ public class KeyValueColumnizeTests extends RefineTest {
logger = LoggerFactory.getLogger(this.getClass()); logger = LoggerFactory.getLogger(this.getClass());
} }
// dependencies
RefineServlet servlet;
Project project;
ProjectMetadata pm;
JSONObject options;
ImportingJob job;
SeparatorBasedImporter importer;
@BeforeMethod @BeforeMethod
public void SetUp() throws JSONException, IOException, ModelException { public void SetUp() throws JSONException, IOException, ModelException {
servlet = new RefineServletStub(); servlet = new RefineServletStub();
@ -145,7 +137,7 @@ public class KeyValueColumnizeTests extends RefineTest {
"Value", "Value",
null); null);
Process process = op.createProcess(project, new Properties()); Process process = op.createProcess(project, new Properties());
HistoryEntry historyEntry = process.performImmediate(); process.performImmediate();
int merchantCol = project.columnModel.getColumnByName("merchant").getCellIndex(); int merchantCol = project.columnModel.getColumnByName("merchant").getCellIndex();
int fruitCol = project.columnModel.getColumnByName("fruit").getCellIndex(); int fruitCol = project.columnModel.getColumnByName("fruit").getCellIndex();