From 1e2c0c0a044db24d18594ff41a7fc9ae87bf1150 Mon Sep 17 00:00:00 2001
From: Owen Stephens <owen@ostephens.com>
Date: Thu, 10 May 2018 16:37:11 -0400
Subject: [PATCH] Added tests for getting non-existent fields and changed test
 for parser eval error

---
 .../google/refine/tests/grel/GrelTests.java   | 26 ++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/main/tests/server/src/com/google/refine/tests/grel/GrelTests.java b/main/tests/server/src/com/google/refine/tests/grel/GrelTests.java
index 24377f30d..e52dc1b90 100644
--- a/main/tests/server/src/com/google/refine/tests/grel/GrelTests.java
+++ b/main/tests/server/src/com/google/refine/tests/grel/GrelTests.java
@@ -99,7 +99,7 @@ public class GrelTests extends RefineTest {
     public void testEvalError() {
         String tests[] = {
 //                "1=1", // TODO: Throws NullPointerException
-                "a.value",
+                "value.datePart()",
                 };
         for (String test : tests) {
             try {
@@ -166,6 +166,26 @@ public class GrelTests extends RefineTest {
             parseEval(bindings, test);
         }
     }
+
+    @Test
+    public void testGetJsonFieldExists() throws ParsingException {
+        String test[] = { "\"[{\\\"one\\\": \\\"1\\\"}]\".parseJson()[0].one", "1" };
+        parseEval(bindings, test);
+    }
+
+    @Test
+    public void testGetJsonFieldAbsent() throws ParsingException {
+        String test =  "\"[{\\\"one\\\": \\\"1\\\"}]\".parseJson()[0].two";
+        Evaluable eval = MetaParser.parse("grel:" + test);
+        Assert.assertNull(eval.evaluate(bindings));
+    }
+
+    @Test
+    public void testGetFieldFromNull() throws ParsingException {
+        String test =  "null.value";
+        Evaluable eval = MetaParser.parse("grel:" + test);
+        Assert.assertNull(eval.evaluate(bindings));
+    }
     
     // to demonstrate bug fixing for #1204
     @Test
@@ -182,11 +202,11 @@ public class GrelTests extends RefineTest {
     }
     
     private void parseEval(Properties bindings, String[] test)
-            throws ParsingException {
+    throws ParsingException {
         Evaluable eval = MetaParser.parse("grel:" + test[0]);
         Object result = eval.evaluate(bindings);
         Assert.assertEquals(result.toString(), test[1], 
-                "Wrong result for expression: "+test[0]);
+                            "Wrong result for expression: "+test[0]);
     }
 
 }