s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix exceptions when constraints are not or incorrectly provided

Browse Source
This commit is contained in:
Antonin Delpeuch 2018-01-11 11:33:06 +00:00
parent 6c6151ca43
commit 2687741263
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/wikidata/src/org/openrefine/wikidata/qa/ConstraintFetcher.java
View File

@ -187,7 +187,11 @@ public class ConstraintFetcher {
protected List<Statement> getConstraintStatements(PropertyIdValue pid) { protected List<Statement> getConstraintStatements(PropertyIdValue pid) {
PropertyDocument doc = (PropertyDocument) EntityCache.getEntityDocument(pid); PropertyDocument doc = (PropertyDocument) EntityCache.getEntityDocument(pid);
StatementGroup group = doc.findStatementGroup(WIKIDATA_CONSTRAINT_PID); StatementGroup group = doc.findStatementGroup(WIKIDATA_CONSTRAINT_PID);
return group.getStatements(); if (group != null) {
return group.getStatements();
} else {
return new ArrayList<Statement>();
}
} }
/** /**

3
extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/FormatConstraintScrutinizer.java
View File

@ -53,6 +53,9 @@ public class FormatConstraintScrutinizer extends SnakScrutinizer {
String value = ((StringValue) snak.getValue()).getString(); String value = ((StringValue) snak.getValue()).getString();
PropertyIdValue pid = snak.getPropertyId(); PropertyIdValue pid = snak.getPropertyId();
Pattern pattern = getPattern(pid); Pattern pattern = getPattern(pid);
if (pattern == null) {
return;
}
if (!pattern.matcher(value).matches()) { if (!pattern.matcher(value).matches()) {
if (added) { if (added) {
QAWarning issue = new QAWarning( QAWarning issue = new QAWarning(