From 8816cd511a55213e65aec21c3d5a2b407605fe63 Mon Sep 17 00:00:00 2001
From: Alex <oleksandr.barabanov@gmail.com>
Date: Mon, 2 Mar 2020 14:57:02 +0200
Subject: [PATCH 1/2] changes for #898: * made "Columnize by Key/Value columns"
 dialog resizable * set overflow styling, which solves the issue in
 Chromium-based browsers (Chrome, Edge, Opera) but doesn't work in FireFox and
 WebKit-based browsers (like Epiphany @ Linux, not tested in Safari but most
 likely won't work either)

---
 .../scripts/views/data-table/key-value-columnize.html  |  6 +++---
 .../core/scripts/views/data-table/menu-edit-cells.js   | 10 ++++++++++
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html b/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html
index c9972fa91..3fa1bd4a5 100644
--- a/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html
+++ b/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html
@@ -9,9 +9,9 @@
           <td bind="or_views_noteCol"></td>
         </tr>
         <tr>
-          <td><select bind="keyColumnSelect" size="15" style="width: 100%;"></select></td>
-          <td><select bind="valueColumnSelect" size="15" style="width: 100%;"></select></td>
-          <td><select bind="noteColumnSelect" size="15" style="width: 100%;"></select></td>
+          <td><select bind="keyColumnSelect" size="15" style="width: 100%; overflow: auto;"></select></td>
+          <td><select bind="valueColumnSelect" size="15" style="width: 100%; overflow: auto;"></select></td>
+          <td><select bind="noteColumnSelect" size="15" style="width: 100%; overflow: auto;"></select></td>
         </tr>
       </table></div>
     </div>
diff --git a/main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js b/main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js
index a1191ecbb..9ca44d665 100644
--- a/main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js
+++ b/main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js
@@ -679,6 +679,16 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
 
       $('<option>').attr("value", column2.name).text(column2.name).appendTo(elmts.noteColumnSelect);
     }
+
+    var currentHeight = dialog.outerHeight();
+    var currentWidth = dialog.outerWidth();
+    dialog.resizable({
+      alsoResize: ".dialog-border .dialog-body",
+      handles: "e, w, se",
+      minHeight: currentHeight,
+      maxHeight: currentHeight,
+      minWidth: currentWidth
+    });
   };
 
   MenuSystem.appendTo(menu, [ "core/transpose" ], [

From 7a3b3a9a7a92411d5d6a7fe99854296b1d1c56a4 Mon Sep 17 00:00:00 2001
From: Antonin Delpeuch <antonin@delpeuch.eu>
Date: Wed, 4 Mar 2020 09:43:42 +0000
Subject: [PATCH 2/2] Enforce uniform column widths in key-value columnize
 dialog

---
 .../core/scripts/views/data-table/key-value-columnize.html    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html b/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html
index 3fa1bd4a5..f67fdf1e3 100644
--- a/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html
+++ b/main/webapp/modules/core/scripts/views/data-table/key-value-columnize.html
@@ -2,7 +2,7 @@
   <div class="dialog-border">
     <div class="dialog-header" bind="dialogHeader"></div>
     <div class="dialog-body" bind="dialogBody">
-      <div class="grid-layout layout-normal layout-full grid-layout-for-ui"><table>
+      <div class="grid-layout layout-normal layout-full grid-layout-for-ui"><table style="table-layout: fixed">
         <tr>
           <td bind="or_views_keyCol"></td>
           <td bind="or_views_valCol"></td>
@@ -20,4 +20,4 @@
       <button class="button" bind="cancelButton"></button>
     </div>
   </div>
-</div>
\ No newline at end of file
+</div>