s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Also trim monolingual text values.

Browse Source
This commit is contained in:
Antonin Delpeuch 2018-11-01 15:33:26 +00:00
parent 8b4cf84bfd
commit 604666ed6a
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/wikidata/src/org/openrefine/wikidata/schema/WbMonolingualExpr.java
View File

@ -53,7 +53,7 @@ public class WbMonolingualExpr implements WbExpression<MonolingualTextValue> {
String text = getValueExpr().evaluate(ctxt).getString(); String text = getValueExpr().evaluate(ctxt).getString();
try { try {
String lang = getLanguageExpr().evaluate(ctxt); String lang = getLanguageExpr().evaluate(ctxt);
return Datamodel.makeMonolingualTextValue(text, lang); return Datamodel.makeMonolingualTextValue(text.trim(), lang);
} catch (SkipSchemaExpressionException e) { } catch (SkipSchemaExpressionException e) {
QAWarning warning = new QAWarning("monolingual-text-without-language", null, QAWarning.Severity.WARNING, 1); QAWarning warning = new QAWarning("monolingual-text-without-language", null, QAWarning.Severity.WARNING, 1);

6
extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbMonolingualExprTest.java
View File

@ -44,6 +44,12 @@ public class WbMonolingualExprTest extends WbExpressionTest<MonolingualTextValue
evaluatesTo(Datamodel.makeMonolingualTextValue("hello", "en"), expr); evaluatesTo(Datamodel.makeMonolingualTextValue("hello", "en"), expr);
} }
@Test
public void testTrim() {
setRow("en", " hello ");
evaluatesTo(Datamodel.makeMonolingualTextValue("hello", "en"), expr);
}
@Test @Test
public void testInvalidLanguageCode() { public void testInvalidLanguageCode() {
setRow("ueuue", "my label"); setRow("ueuue", "my label");