s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't assume notable types are returned by Suggest

Browse Source 
Freebase Suggest doesn't always return a notable key in its dictionary,
so we need to check whether it exits.  Fixes issue #636
This commit is contained in:
Tom Morris 2012-11-20 14:03:35 -05:00
parent 14c04698e3
commit 6315036c82
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
main/webapp/modules/core/scripts/views/data-table/cell-ui.js
View File

@ -326,13 +326,17 @@ DataTableCellUI.prototype._searchForMatch = function(suggestOptions) {
var match = null; var match = null;
var commit = function() { var commit = function() {
if (match !== null) { if (match !== null) {
var notable_types = null;
if (match.notable) {
notable_types = $.map(match.notable, function(elmt) {
return typeof elmt == "string" ? elmt : elmt.id;
}).join(",");
}
var params = { var params = {
judgment: "matched", judgment: "matched",
id: match.id, id: match.id,
name: match.name, name: match.name,
types: $.map(match.notable, function(elmt) { types: notable_types
return typeof elmt == "string" ? elmt : elmt.id;
}).join(",")
}; };
if (elmts.radioSimilar[0].checked) { if (elmts.radioSimilar[0].checked) {