s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed issue 4: Match All bug with ZIP code.

Browse Source 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@767 7d457c2a-affb-35e4-300a-418c747d4874
This commit is contained in:
David Huynh 2010-05-14 17:03:33 +00:00
parent bd87e079b2
commit 6450921c02
2 changed files with 56 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES.txt
View File

@ -3,7 +3,8 @@ Ongoing
Fixes: Fixes:
- Issue 34: "Behavior of Text Filter is unpredictable when "regular expression" mode is enabled." - Issue 34: "Behavior of Text Filter is unpredictable when "regular expression" mode is enabled."
Regex was not compiled with case insensitivity flag. Regex was not compiled with case insensitivity flag.
- Issue 4: "Match All bug with ZIP code". Numeric values in cells were not stringified first
before comparison.
1.0.1 Release (May 12, 2010) 1.0.1 Release (May 12, 2010)

8
src/main/java/com/metaweb/gridworks/operations/ReconJudgeSimilarCellsOperation.java
View File

@ -164,10 +164,11 @@ public class ReconJudgeSimilarCellsOperation extends EngineDependentMassCellOper
public boolean visit(Project project, int rowIndex, Row row, boolean includeContextual, boolean includeDependent) { public boolean visit(Project project, int rowIndex, Row row, boolean includeContextual, boolean includeDependent) {
Cell cell = row.getCell(_cellIndex); Cell cell = row.getCell(_cellIndex);
if (cell != null && if (cell != null && ExpressionUtils.isNonBlankData(cell.value)) {
ExpressionUtils.isNonBlankData(cell.value) && String value = cell.value instanceof String ?
_similarValue.equals(cell.value)) { ((String) cell.value) : cell.value.toString();
if (_similarValue.equals(value)) {
Recon recon = null; Recon recon = null;
if (_judgment == Judgment.New && _shareNewTopics) { if (_judgment == Judgment.New && _shareNewTopics) {
if (_sharedNewRecon == null) { if (_sharedNewRecon == null) {
@ -218,6 +219,7 @@ public class ReconJudgeSimilarCellsOperation extends EngineDependentMassCellOper
CellChange cellChange = new CellChange(rowIndex, _cellIndex, cell, newCell); CellChange cellChange = new CellChange(rowIndex, _cellIndex, cell, newCell);
_cellChanges.add(cellChange); _cellChanges.add(cellChange);
} }
}
return false; return false;
} }
}.init(column.getCellIndex(), cellChanges, historyEntryID); }.init(column.getCellIndex(), cellChanges, historyEntryID);