s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Temporary deserialization bug fix for extension operations"

Browse Source 
This reverts commit 7ff4a453d3.
This commit is contained in:
Antonin Delpeuch 2018-12-07 10:24:59 +09:00
parent a7c68f06ec
commit 6a10765a83
2 changed files with 2 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
extensions/wikidata/src/org/openrefine/wikidata/operations/PerformWikibaseEditsOperation.java
View File

@ -75,28 +75,6 @@ public class PerformWikibaseEditsOperation extends EngineDependentOperation {
Validate.notEmpty(summary, "An edit summary must be provided.");
this.summary = summary;
}
/* The constructor above should be enough for deserialization,
* but for some unknown reason it can fail in certain cases
* (might be due to caching deserializers across threads?)
*
* So we sadly add a default constructor and a setter below.
*
* TODO delete the default constructor and setter, make summary final
*/
public PerformWikibaseEditsOperation() {
super(null);
}
@JsonProperty("engineConfig")
public void setEngineConfig(EngineConfig config) {
this._engineConfig = config;
}
@JsonProperty("summary")
public void setSummary(String summary) {
this.summary = summary;
}
@Override
protected String getBriefDescription(Project project) {

20
extensions/wikidata/src/org/openrefine/wikidata/operations/SaveWikibaseSchemaOperation.java
View File

@ -46,30 +46,14 @@ public class SaveWikibaseSchemaOperation extends AbstractOperation {
@JsonIgnore
final public static String operationDescription = "Save Wikibase schema";
@JsonProperty("schema")
protected WikibaseSchema _schema;
final protected WikibaseSchema _schema;
@JsonCreator
public SaveWikibaseSchemaOperation(
@JsonProperty("schema")
WikibaseSchema schema) {
this._schema = schema;
}
/* The constructor above should be enough for deserialization,
* but for some unknown reason it can fail in certain cases
* (might be due to caching deserializers across threads?)
*
* So we sadly add a default constructor and a setter below.
*
* TODO delete the default constructor and setter, make schema final
*/
public SaveWikibaseSchemaOperation() {
}
@JsonProperty("schema")
public void setSchema(WikibaseSchema schema) {
this._schema = schema;
}
@Override