From 761f88534839cd6ae68b406e313cb35f544f8d0c Mon Sep 17 00:00:00 2001 From: Antonin Delpeuch Date: Mon, 12 Mar 2018 14:00:15 +0000 Subject: [PATCH] Fix missing label for QS export --- extensions/wikidata/module/scripts/menu-bar-extension.js | 2 +- .../wikidata/commands/PreviewWikibaseSchemaCommand.java | 6 ++---- .../wikidata/commands/SaveWikibaseSchemaCommand.java | 4 ++-- .../org/openrefine/wikidata/exporters/QSValuePrinter.java | 1 + .../wikidata/exporters/QuickStatementsExporter.java | 8 ++++---- .../wikidata/qa/scrutinizers/EditScrutinizer.java | 2 -- .../wikidata/qa/scrutinizers/NoEditsMadeScrutinizer.java | 2 -- .../src/org/openrefine/wikidata/updates/ItemUpdate.java | 6 +++--- .../openrefine/wikidata/updates/ItemUpdateBuilder.java | 2 +- .../org/openrefine/wikidata/utils/JacksonJsonizable.java | 2 +- 10 files changed, 15 insertions(+), 20 deletions(-) diff --git a/extensions/wikidata/module/scripts/menu-bar-extension.js b/extensions/wikidata/module/scripts/menu-bar-extension.js index 7a23826c3..0c69d2a3f 100644 --- a/extensions/wikidata/module/scripts/menu-bar-extension.js +++ b/extensions/wikidata/module/scripts/menu-bar-extension.js @@ -20,7 +20,7 @@ ExporterManager.MenuItems.push({}); ExporterManager.MenuItems.push( { "id" : "exportQuickStatements", - "label": $.i18n._('wikidata-extions')["quickstatements-export-name"], + "label": $.i18n._('wikidata-extension')["quickstatements-export-name"], "click": function() { WikibaseExporterMenuBar.exportTo("quickstatements"); } } ); diff --git a/extensions/wikidata/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommand.java b/extensions/wikidata/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommand.java index b38e8efb8..ca71df77a 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommand.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommand.java @@ -35,10 +35,6 @@ import javax.servlet.http.HttpServletResponse; import org.json.JSONException; import org.json.JSONWriter; - -import com.google.refine.browsing.Engine; -import com.google.refine.commands.Command; - import org.openrefine.wikidata.exporters.QuickStatementsExporter; import org.openrefine.wikidata.qa.EditInspector; import org.openrefine.wikidata.qa.QAWarning; @@ -47,6 +43,8 @@ import org.openrefine.wikidata.schema.WikibaseSchema; import org.openrefine.wikidata.updates.ItemUpdate; import org.openrefine.wikidata.utils.FirstLinesExtractor; +import com.google.refine.browsing.Engine; +import com.google.refine.commands.Command; import com.google.refine.model.Project; public class PreviewWikibaseSchemaCommand extends Command { diff --git a/extensions/wikidata/src/org/openrefine/wikidata/commands/SaveWikibaseSchemaCommand.java b/extensions/wikidata/src/org/openrefine/wikidata/commands/SaveWikibaseSchemaCommand.java index f45cace84..0fd70fa8e 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/commands/SaveWikibaseSchemaCommand.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/commands/SaveWikibaseSchemaCommand.java @@ -30,10 +30,10 @@ import javax.servlet.ServletException; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; -import org.openrefine.wikidata.operations.SaveWikibaseSchemaOperation; -import org.openrefine.wikidata.schema.WikibaseSchema; import org.json.JSONException; import org.json.JSONObject; +import org.openrefine.wikidata.operations.SaveWikibaseSchemaOperation; +import org.openrefine.wikidata.schema.WikibaseSchema; import com.google.refine.commands.Command; import com.google.refine.model.AbstractOperation; diff --git a/extensions/wikidata/src/org/openrefine/wikidata/exporters/QSValuePrinter.java b/extensions/wikidata/src/org/openrefine/wikidata/exporters/QSValuePrinter.java index c2903d876..4a4153f57 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/exporters/QSValuePrinter.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/exporters/QSValuePrinter.java @@ -27,6 +27,7 @@ import java.math.BigDecimal; import java.util.Locale; import org.openrefine.wikidata.schema.entityvalues.ReconEntityIdValue; +import org.openrefine.wikidata.updates.scheduler.QuickStatementsUpdateScheduler; import org.wikidata.wdtk.datamodel.interfaces.DatatypeIdValue; import org.wikidata.wdtk.datamodel.interfaces.EntityIdValue; import org.wikidata.wdtk.datamodel.interfaces.GlobeCoordinatesValue; diff --git a/extensions/wikidata/src/org/openrefine/wikidata/exporters/QuickStatementsExporter.java b/extensions/wikidata/src/org/openrefine/wikidata/exporters/QuickStatementsExporter.java index cf6f35905..6bc650bf8 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/exporters/QuickStatementsExporter.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/exporters/QuickStatementsExporter.java @@ -29,10 +29,6 @@ import java.util.List; import java.util.Properties; import java.util.Set; -import com.google.refine.browsing.Engine; -import com.google.refine.exporters.WriterExporter; -import com.google.refine.model.Project; - import org.openrefine.wikidata.schema.WikibaseSchema; import org.openrefine.wikidata.updates.ItemUpdate; import org.openrefine.wikidata.updates.scheduler.ImpossibleSchedulingException; @@ -49,6 +45,10 @@ import org.wikidata.wdtk.datamodel.interfaces.Statement; import org.wikidata.wdtk.datamodel.interfaces.Value; import org.wikidata.wdtk.datamodel.interfaces.ValueVisitor; +import com.google.refine.browsing.Engine; +import com.google.refine.exporters.WriterExporter; +import com.google.refine.model.Project; + public class QuickStatementsExporter implements WriterExporter { final static Logger logger = LoggerFactory.getLogger("QuickStatementsExporter"); diff --git a/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/EditScrutinizer.java b/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/EditScrutinizer.java index ad57ebc23..44ab9cff5 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/EditScrutinizer.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/EditScrutinizer.java @@ -23,8 +23,6 @@ ******************************************************************************/ package org.openrefine.wikidata.qa.scrutinizers; -import java.util.List; - import org.openrefine.wikidata.qa.ConstraintFetcher; import org.openrefine.wikidata.qa.QAWarning; import org.openrefine.wikidata.qa.QAWarning.Severity; diff --git a/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/NoEditsMadeScrutinizer.java b/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/NoEditsMadeScrutinizer.java index 4e9e8ae3c..27e653b03 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/NoEditsMadeScrutinizer.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/NoEditsMadeScrutinizer.java @@ -23,8 +23,6 @@ ******************************************************************************/ package org.openrefine.wikidata.qa.scrutinizers; -import java.util.List; - import org.openrefine.wikidata.updates.ItemUpdate; public class NoEditsMadeScrutinizer extends EditScrutinizer { diff --git a/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdate.java b/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdate.java index 3dcb32932..7f2ba76a3 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdate.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdate.java @@ -25,19 +25,19 @@ package org.openrefine.wikidata.updates; import java.util.ArrayList; import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; import java.util.List; import java.util.Map; import java.util.Set; import java.util.stream.Collectors; -import java.util.HashMap; -import java.util.HashSet; import org.jsoup.helper.Validate; import org.wikidata.wdtk.datamodel.implementation.StatementGroupImpl; import org.wikidata.wdtk.datamodel.interfaces.EntityIdValue; -import org.wikidata.wdtk.datamodel.interfaces.PropertyIdValue; import org.wikidata.wdtk.datamodel.interfaces.ItemIdValue; import org.wikidata.wdtk.datamodel.interfaces.MonolingualTextValue; +import org.wikidata.wdtk.datamodel.interfaces.PropertyIdValue; import org.wikidata.wdtk.datamodel.interfaces.Statement; import org.wikidata.wdtk.datamodel.interfaces.StatementGroup; diff --git a/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdateBuilder.java b/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdateBuilder.java index a3dcb1b12..1556370c0 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdateBuilder.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdateBuilder.java @@ -23,10 +23,10 @@ ******************************************************************************/ package org.openrefine.wikidata.updates; -import java.util.Set; import java.util.ArrayList; import java.util.HashSet; import java.util.List; +import java.util.Set; import org.jsoup.helper.Validate; import org.wikidata.wdtk.datamodel.interfaces.ItemIdValue; diff --git a/extensions/wikidata/src/org/openrefine/wikidata/utils/JacksonJsonizable.java b/extensions/wikidata/src/org/openrefine/wikidata/utils/JacksonJsonizable.java index c55249b9b..b84c79b7d 100644 --- a/extensions/wikidata/src/org/openrefine/wikidata/utils/JacksonJsonizable.java +++ b/extensions/wikidata/src/org/openrefine/wikidata/utils/JacksonJsonizable.java @@ -27,8 +27,8 @@ import java.io.IOException; import java.util.Properties; import org.json.JSONException; -import org.json.JSONWriter; import org.json.JSONObject; +import org.json.JSONWriter; import com.fasterxml.jackson.annotation.JsonIgnoreProperties; import com.fasterxml.jackson.core.JsonParseException;