s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

changes based on the code review

Browse Source
This commit is contained in:
Jacky 2018-03-01 22:45:14 -05:00
parent c758a6b635
commit 77aad7eb05
4 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/gdata/module/langs/translation-en.json
View File

@ -44,7 +44,7 @@
"gdata-exporter": { "gdata-exporter": {
"uploading": "Uploading...", "uploading": "Uploading...",
"upload-error": "Upload error: ", "upload-error": "Upload error: ",
"upload-success": "Project was exported successfully to google drive with Id ", "upload-success": "Project was uploaded successfully to Google Drive with Id ",
"new-spreadsheet": "A new Google spreadsheet", "new-spreadsheet": "A new Google spreadsheet",
"enter-spreadsheet": "Enter a name for the new Google spreadsheet", "enter-spreadsheet": "Enter a name for the new Google spreadsheet",
"new-fusion": "A new Google Fusion table", "new-fusion": "A new Google Fusion table",

7
extensions/gdata/src/com/google/refine/extension/gdata/SpreadsheetSerializer.java
View File

@ -1,6 +1,8 @@
package com.google.refine.extension.gdata; package com.google.refine.extension.gdata;
import java.io.IOException; import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.net.URLEncoder;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@ -115,7 +117,8 @@ final class SpreadsheetSerializer implements TabularSerializer {
requests.add(batchRequest); requests.add(batchRequest);
} }
public String getUrl() { public String getUrl() throws UnsupportedEncodingException {
return "https://docs.google.com/spreadsheets/d/" + spreadsheetId + "/edit#gid=0"; String urlString= "https://docs.google.com/spreadsheets/d/" + spreadsheetId + "/edit#gid=0";
return URLEncoder.encode(urlString, "UTF-8");
} }
} }

2
main/src/com/google/refine/importing/ImportingUtilities.java
View File

@ -88,8 +88,6 @@ import org.json.JSONObject;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import com.beust.jcommander.Strings;
import com.google.refine.ProjectManager; import com.google.refine.ProjectManager;
import com.google.refine.RefineServlet; import com.google.refine.RefineServlet;
import com.google.refine.importing.ImportingManager.Format; import com.google.refine.importing.ImportingManager.Format;

2
main/webapp/modules/core/langs/translation-en.json
View File

@ -275,7 +275,7 @@
"json-text": "The following JSON text encodes the options you have set in the other tabs. You can copy it out and save it for later, and paste it back in and click Apply to re-use the same options.", "json-text": "The following JSON text encodes the options you have set in the other tabs. You can copy it out and save it for later, and paste it back in and click Apply to re-use the same options.",
"choose-export-destination": "Please choose the destination for project export", "choose-export-destination": "Please choose the destination for project export",
"export-to-local": "Export to local", "export-to-local": "Export to local",
"export-to-google-drive": "Export to google drive" "export-to-google-drive": "Export to Google Drive"
}, },
"core-facets": { "core-facets": {
"remove-facet": "Remove this facet", "remove-facet": "Remove this facet",