s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Give a reasonable error message on Excel 95 import failure - fixes #564

Browse Source
This commit is contained in:
Tom Morris 2013-07-26 16:24:56 -04:00
parent ff4eeb549a
commit 7edc550618
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
main/src/com/google/refine/importers/ExcelImporter.java
View File

@ -115,6 +115,8 @@ public class ExcelImporter extends TabularImportingParserBase {
} }
} catch (IOException e) { } catch (IOException e) {
logger.error("Error generating parser UI initialization data for Excel file", e); logger.error("Error generating parser UI initialization data for Excel file", e);
} catch (IllegalArgumentException e) {
logger.error("Error generating parser UI initialization data for Excel file (only Excel 97 & later supported)", e);
} }
return options; return options;
@ -153,6 +155,13 @@ public class ExcelImporter extends TabularImportingParserBase {
e e
)); ));
return; return;
} catch (IllegalArgumentException e) {
exceptions.add(new ImportException(
"Attempted to parse as an Excel file but failed. " +
"Only Excel 97 and later formats are supported.",
e
));
return;
} }
int[] sheets = JSONUtilities.getIntArray(options, "sheets"); int[] sheets = JSONUtilities.getIntArray(options, "sheets");

BIN
main/tests/server/src/com/google/refine/tests/importers/excel95.xls Normal file
View File

Binary file not shown.