From 84af07506d30861fb0a69ab0b42decbbe8fdfdb0 Mon Sep 17 00:00:00 2001 From: Fabian Steeg Date: Fri, 4 Oct 2019 14:55:34 +0200 Subject: [PATCH] Prefer view.url pattern for data extension preview links See https://github.com/OpenRefine/OpenRefine/issues/2177 --- .../core/scripts/dialogs/extend-data-preview-dialog.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js b/main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js index 1009e872c..d60d9440c 100644 --- a/main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js +++ b/main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js @@ -283,9 +283,11 @@ ExtendReconciledDataPreviewDialog.prototype._renderPreview = function(data) { var cell = row[c]; if (cell !== null) { if ($.isPlainObject(cell)) { - $('').attr("href", - this._serviceMetadata.identifierSpace + cell.id - ).attr("target", "_blank").text(cell.name).appendTo(td); + var service = self._serviceMetadata; + var href = (service.view && service.view.url) ? + encodeURI(service.view.url.replace("{{id}}", cell.id)) : + service.identifierSpace + cell.id; + $('').attr("href", href).attr("target", "_blank").text(cell.name).appendTo(td); } else { $('').text(cell).appendTo(td); }