s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix editing preference with old value (#2769)

Browse Source 
Fix the editing of a pref that proposed the oldest value of a preference, instead of the current value
This commit is contained in:
Antoine Beaubien 2021-01-27 03:07:03 -05:00 committed by GitHub
parent a2ed9d586a
commit 8b978d1336
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
main/webapp/modules/core/scripts/preferences.js
View File

@ -103,19 +103,19 @@ function deDupUserMetaData(arrObj) {
return JSON.stringify(result).replace(/"/g, '\"'); return JSON.stringify(result).replace(/"/g, '\"');
} }
function PreferenceUI(tr, key, value) { function PreferenceUI(tr, key, initialValue) {
var self = this; var self = this;
var td0 = tr.insertCell(0); var td0 = tr.insertCell(0);
$(td0).text(key); $(td0).text(key);
var td1 = tr.insertCell(1); var td1 = tr.insertCell(1);
$(td1).text((value !== null) ? value : ""); $(td1).text((initialValue !== null) ? initialValue : "");
var td2 = tr.insertCell(2); var td2 = tr.insertCell(2);
$('<button class="button">').text($.i18n('core-index/edit')).appendTo(td2).click(function() { $('<button class="button">').text($.i18n('core-index/edit')).appendTo(td2).click(function() {
var newValue = window.prompt($.i18n('core-index/change-value')+" " + key, value); var newValue = window.prompt($.i18n('core-index/change-value')+" " + key, $(td1).text());
if (newValue !== null) { if (newValue !== null) {
if (key === "userMetadata") { if (key === "userMetadata") {
newValue = deDupUserMetaData(newValue); newValue = deDupUserMetaData(newValue);