From 93d6e176d6380a42f4bdd7815d68acc4ac451932 Mon Sep 17 00:00:00 2001 From: Tom Morris Date: Fri, 7 Sep 2012 21:17:34 +0000 Subject: [PATCH] Task 478: Default "guess datatypes" to False so importers which don't specify it (e.g. gData & Excel) aren't effected http://code.google.com/p/google-refine/issues/detail?id=478 git-svn-id: http://google-refine.googlecode.com/svn/trunk@2541 7d457c2a-affb-35e4-300a-418c747d4874 --- .../google/refine/importers/TabularImportingParserBase.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main/src/com/google/refine/importers/TabularImportingParserBase.java b/main/src/com/google/refine/importers/TabularImportingParserBase.java index d19d3b5a7..e1118a59e 100644 --- a/main/src/com/google/refine/importers/TabularImportingParserBase.java +++ b/main/src/com/google/refine/importers/TabularImportingParserBase.java @@ -103,7 +103,7 @@ abstract public class TabularImportingParserBase extends ImportingParserBase { } } - boolean guessCellValueTypes = JSONUtilities.getBoolean(options, "guessCellValueTypes", true); + boolean guessCellValueTypes = JSONUtilities.getBoolean(options, "guessCellValueTypes", false); boolean storeBlankRows = JSONUtilities.getBoolean(options, "storeBlankRows", true); boolean storeBlankCellsAsNulls = JSONUtilities.getBoolean(options, "storeBlankCellsAsNulls", true); @@ -172,7 +172,7 @@ abstract public class TabularImportingParserBase extends ImportingParserBase { project, columnNames, c, hasOurOwnColumnNames); Object value = cells.get(c); - if (value != null && value instanceof Cell) { + if (value instanceof Cell) { row.setCell(column.getCellIndex(), (Cell) value); rowHasData = true; } else if (ExpressionUtils.isNonBlankData(value)) {