s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Hmm, String.split() bites us again: use the commons-lang one instead to avoid having to escape regexp values (this was preventing a user from splitting by "." in GEL)

Browse Source 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@370 7d457c2a-affb-35e4-300a-418c747d4874
This commit is contained in:
Stefano Mazzocchi 2010-04-01 17:49:31 +00:00
parent 0e07ec7acc
commit 988378c761
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/com/metaweb/gridworks/expr/functions/strings/Split.java
View File

@ -3,6 +3,7 @@ package com.metaweb.gridworks.expr.functions.strings;
import java.util.Properties; import java.util.Properties;
import java.util.regex.Pattern; import java.util.regex.Pattern;
import org.apache.commons.lang.StringUtils;
import org.json.JSONException; import org.json.JSONException;
import org.json.JSONWriter; import org.json.JSONWriter;
@ -19,7 +20,7 @@ public class Split implements Function {
if (v != null && split != null) { if (v != null && split != null) {
String str = (v instanceof String ? (String) v : v.toString()); String str = (v instanceof String ? (String) v : v.toString());
if (split instanceof String) { if (split instanceof String) {
return str.split((String) split); return StringUtils.splitByWholeSeparator(str, (String) split);
} else if (split instanceof Pattern) { } else if (split instanceof Pattern) {
Pattern pattern = (Pattern) split; Pattern pattern = (Pattern) split;
return pattern.split(str); return pattern.split(str);