From 9a5cb644ecebf53b4ab69d4896998c3676447a7a Mon Sep 17 00:00:00 2001 From: Lu Liu <2w6f8c@gmail.com> Date: Fri, 13 Mar 2020 16:38:56 +0800 Subject: [PATCH] Use parentheses for JAVA_OPTIONS on Unix/Linux (#2401) * use parentheses for JAVA_OPTIONS on Unix/Linux * change regex in refine * add comment for JAVA_OPTIONS * Update refine.ini Co-Authored-By: Thad Guidry * Update refine.ini Co-Authored-By: Thad Guidry * Update refine.ini Co-Authored-By: Thad Guidry Co-authored-by: Thad Guidry --- refine | 2 +- refine.ini | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/refine b/refine index 1e81636cc..5b549125e 100755 --- a/refine +++ b/refine @@ -103,7 +103,7 @@ load_configs() { if [ "${TEMP_CONFIG}" = "" ] ; then error "Could not create temporary file to load configurations" fi - cat $1 | egrep "^[A-Z]" | sed 's/^\(.*\)$/export \1/' > ${TEMP_CONFIG} + cat $1 | egrep "^[A-Z]" | sed 's/^\([^=]*\)=\(.*\)$/export \1=(\2)/' > ${TEMP_CONFIG} . ${TEMP_CONFIG} rm ${TEMP_CONFIG} } diff --git a/refine.ini b/refine.ini index 2e22bb314..eefb7760c 100644 --- a/refine.ini +++ b/refine.ini @@ -15,8 +15,8 @@ REFINE_MIN_MEMORY=1400M # Some sample configurations. These have no defaults. #JAVA_HOME=C:\Program Files\Java\jdk1.8.0_151 -#JAVA_OPTIONS=-XX:+UseParallelGC -verbose:gc -Drefine.headless=true -#JAVA_OPTIONS=-Drefine.data_dir=C:\Users\user\AppData\Roaming\OpenRefine +# Use a single JAVA_OPTIONS that includes any JVM options you need upon OpenRefine startup +#JAVA_OPTIONS=-XX:+UseParallelGC -verbose:gc -Drefine.headless=true -Drefine.data_dir=C:\Users\user\AppData\Roaming\OpenRefine # Uncomment to increase autosave period to 60 mins (default: 5 minutes) for better performance of long-lasting transformations #REFINE_AUTOSAVE_PERIOD=60 @@ -29,4 +29,4 @@ REFINE_MIN_MEMORY=1400M # The wiki will guide you to get a client_id/client_secret pair # After getting the client_id and client_secret, put them below #GDATA_CLIENT_ID=your_client_id -#GDATA_CLIENT_SECRET=your_client_secret \ No newline at end of file +#GDATA_CLIENT_SECRET=your_client_secret