s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Implemented QualifierComaptibilty Scrutinizer tests using Mockito (#2860)

Browse Source 
Updated test cases & added AlLowedQualifierConstraint and MandatoryQualifierConstraint classes.
This commit is contained in:
Ekta Mishra 2020-07-02 17:52:50 +05:30 committed by GitHub
parent 67bc8581ce
commit 9dfb9114c4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 131 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/QualifierCompatibilityScrutinizer.java
View File

@ -23,16 +23,19 @@
******************************************************************************/ ******************************************************************************/
package org.openrefine.wikidata.qa.scrutinizers; package org.openrefine.wikidata.qa.scrutinizers;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;
import org.openrefine.wikidata.qa.QAWarning; import org.openrefine.wikidata.qa.QAWarning;
import org.wikidata.wdtk.datamodel.interfaces.EntityIdValue; import org.wikidata.wdtk.datamodel.interfaces.EntityIdValue;
import org.wikidata.wdtk.datamodel.interfaces.PropertyIdValue; import org.wikidata.wdtk.datamodel.interfaces.PropertyIdValue;
import org.wikidata.wdtk.datamodel.interfaces.SnakGroup;
import org.wikidata.wdtk.datamodel.interfaces.Statement; import org.wikidata.wdtk.datamodel.interfaces.Statement;
import org.wikidata.wdtk.datamodel.interfaces.Value;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;
/** /**
* A scrutinizer that checks the compatibility of the qualifiers and the * A scrutinizer that checks the compatibility of the qualifiers and the
@ -44,6 +47,42 @@ public class QualifierCompatibilityScrutinizer extends StatementScrutinizer {
public static final String missingMandatoryQualifiersType = "missing-mandatory-qualifiers"; public static final String missingMandatoryQualifiersType = "missing-mandatory-qualifiers";
public static final String disallowedQualifiersType = "disallowed-qualifiers"; public static final String disallowedQualifiersType = "disallowed-qualifiers";
public static String ALLOWED_QUALIFIERS_CONSTRAINT_QID = "Q21510851";
public static String ALLOWED_QUALIFIERS_CONSTRAINT_PID = "P2306";
public static String MANDATORY_QUALIFIERS_CONSTRAINT_QID = "Q21510856";
public static String MANDATORY_QUALIFIERS_CONSTRAINT_PID = "P2306";
class AllowedQualifierConstraint {
Set<PropertyIdValue> allowedProperties;
AllowedQualifierConstraint(Statement statement) {
allowedProperties = new HashSet<>();
List<SnakGroup> specs = statement.getClaim().getQualifiers();
if (specs != null) {
List<Value> properties = _fetcher.findValues(specs, ALLOWED_QUALIFIERS_CONSTRAINT_PID);
allowedProperties = properties.stream()
.filter(e -> e != null)
.map(e -> (PropertyIdValue) e)
.collect(Collectors.toSet());
}
}
}
class MandatoryQualifierConstraint {
Set<PropertyIdValue> mandatoryProperties;
MandatoryQualifierConstraint(Statement statement) {
mandatoryProperties = new HashSet<>();
List<SnakGroup> specs = statement.getClaim().getQualifiers();
if (specs != null) {
List<Value> properties = _fetcher.findValues(specs, MANDATORY_QUALIFIERS_CONSTRAINT_PID);
mandatoryProperties = properties.stream()
.filter(e -> e != null)
.map(e -> (PropertyIdValue) e)
.collect(Collectors.toSet());
}
}
}
private Map<PropertyIdValue, Set<PropertyIdValue>> _allowedQualifiers; private Map<PropertyIdValue, Set<PropertyIdValue>> _allowedQualifiers;
private Map<PropertyIdValue, Set<PropertyIdValue>> _mandatoryQualifiers; private Map<PropertyIdValue, Set<PropertyIdValue>> _mandatoryQualifiers;
@ -58,7 +97,11 @@ public class QualifierCompatibilityScrutinizer extends StatementScrutinizer {
if (_allowedQualifiers.containsKey(statementProperty)) { if (_allowedQualifiers.containsKey(statementProperty)) {
allowed = _allowedQualifiers.get(statementProperty); allowed = _allowedQualifiers.get(statementProperty);
} else { } else {
allowed = _fetcher.allowedQualifiers(statementProperty); List<Statement> statementList = _fetcher.getConstraintsByType(statementProperty, ALLOWED_QUALIFIERS_CONSTRAINT_QID);
if (!statementList.isEmpty()){
AllowedQualifierConstraint allowedQualifierConstraint = new AllowedQualifierConstraint(statementList.get(0));
allowed = allowedQualifierConstraint.allowedProperties;
}
_allowedQualifiers.put(statementProperty, allowed); _allowedQualifiers.put(statementProperty, allowed);
} }
return allowed == null || allowed.contains(qualifierProperty); return allowed == null || allowed.contains(qualifierProperty);
@ -69,7 +112,11 @@ public class QualifierCompatibilityScrutinizer extends StatementScrutinizer {
if (_mandatoryQualifiers.containsKey(statementProperty)) { if (_mandatoryQualifiers.containsKey(statementProperty)) {
mandatory = _mandatoryQualifiers.get(statementProperty); mandatory = _mandatoryQualifiers.get(statementProperty);
} else { } else {
mandatory = _fetcher.mandatoryQualifiers(statementProperty); List<Statement> statementList = _fetcher.getConstraintsByType(statementProperty, MANDATORY_QUALIFIERS_CONSTRAINT_QID);
if (!statementList.isEmpty()){
MandatoryQualifierConstraint mandatoryQualifierConstraint = new MandatoryQualifierConstraint(statementList.get(0));
mandatory = mandatoryQualifierConstraint.mandatoryProperties;
}
if (mandatory == null) { if (mandatory == null) {
mandatory = new HashSet<>(); mandatory = new HashSet<>();
} }

90
extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/QualifierCompatibilityScrutinizerTest.java
View File

@ -23,26 +23,39 @@
******************************************************************************/ ******************************************************************************/
package org.openrefine.wikidata.qa.scrutinizers; package org.openrefine.wikidata.qa.scrutinizers;
import java.util.Arrays; import org.openrefine.wikidata.qa.ConstraintFetcher;
import java.util.Collections;
import java.util.List;
import java.util.stream.Collectors;
import org.openrefine.wikidata.qa.MockConstraintFetcher;
import org.openrefine.wikidata.testing.TestingData; import org.openrefine.wikidata.testing.TestingData;
import org.openrefine.wikidata.updates.ItemUpdate;
import org.openrefine.wikidata.updates.ItemUpdateBuilder;
import org.testng.annotations.Test; import org.testng.annotations.Test;
import org.wikidata.wdtk.datamodel.helpers.Datamodel; import org.wikidata.wdtk.datamodel.helpers.Datamodel;
import org.wikidata.wdtk.datamodel.interfaces.Claim; import org.wikidata.wdtk.datamodel.interfaces.Claim;
import org.wikidata.wdtk.datamodel.interfaces.ItemIdValue;
import org.wikidata.wdtk.datamodel.interfaces.PropertyIdValue;
import org.wikidata.wdtk.datamodel.interfaces.Snak; import org.wikidata.wdtk.datamodel.interfaces.Snak;
import org.wikidata.wdtk.datamodel.interfaces.SnakGroup; import org.wikidata.wdtk.datamodel.interfaces.SnakGroup;
import org.wikidata.wdtk.datamodel.interfaces.Statement; import org.wikidata.wdtk.datamodel.interfaces.Statement;
import org.wikidata.wdtk.datamodel.interfaces.StatementRank; import org.wikidata.wdtk.datamodel.interfaces.StatementRank;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.stream.Collectors;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
public class QualifierCompatibilityScrutinizerTest extends StatementScrutinizerTest { public class QualifierCompatibilityScrutinizerTest extends StatementScrutinizerTest {
private Snak disallowedQualifier = Datamodel.makeNoValueSnak(MockConstraintFetcher.qualifierPid); public static ItemIdValue allowedQualifierEntity = Datamodel.makeWikidataItemIdValue("Q21510851");
private Snak mandatoryQualifier = Datamodel.makeNoValueSnak(MockConstraintFetcher.mandatoryQualifierPid); public static ItemIdValue mandatoryQualifierEntity = Datamodel.makeWikidataItemIdValue("Q21510856");
private Snak allowedQualifier = Datamodel.makeNoValueSnak(MockConstraintFetcher.allowedQualifierPid); public static PropertyIdValue propertyParameterPID = Datamodel.makeWikidataPropertyIdValue("P2306");
public static PropertyIdValue propertyParameterValue = Datamodel.makeWikidataPropertyIdValue("P585");
public static PropertyIdValue allowedPropertyIdValue = Datamodel.makeWikidataPropertyIdValue("P2196");
public static PropertyIdValue mandatoryPropertyIdValue = Datamodel.makeWikidataPropertyIdValue("P2196");
public static PropertyIdValue qualifierProperty = Datamodel.makeWikidataPropertyIdValue("P585");
public static PropertyIdValue disallowedQualifierProperty = Datamodel.makeWikidataPropertyIdValue("P586");
@Override @Override
public EditScrutinizer getScrutinizer() { public EditScrutinizer getScrutinizer() {
@ -51,26 +64,75 @@ public class QualifierCompatibilityScrutinizerTest extends StatementScrutinizerT
@Test @Test
public void testDisallowedQualifier() { public void testDisallowedQualifier() {
ItemIdValue idA = TestingData.existingId;
Snak mainSnak = Datamodel.makeSomeValueSnak(allowedPropertyIdValue);
Snak qualifierSnak = Datamodel.makeSomeValueSnak(disallowedQualifierProperty);
Statement statement = makeStatement(mainSnak, qualifierSnak);
ItemUpdate update = new ItemUpdateBuilder(idA).addStatement(statement).build();
scrutinize(makeStatement(disallowedQualifier, mandatoryQualifier)); Snak snak1 = Datamodel.makeValueSnak(propertyParameterPID, propertyParameterValue);
List<Snak> snakList1 = Collections.singletonList(snak1);
SnakGroup snakGroup1 = Datamodel.makeSnakGroup(snakList1);
List<SnakGroup> snakGroupList = Collections.singletonList(snakGroup1);
List<Statement> statementList = constraintParameterStatementList(allowedQualifierEntity, snakGroupList);
ConstraintFetcher fetcher = mock(ConstraintFetcher.class);
when(fetcher.getConstraintsByType(allowedPropertyIdValue, "Q21510851")).thenReturn(statementList);
when(fetcher.findValues(snakGroupList, "P2306")).thenReturn(Collections.singletonList(qualifierProperty));
setFetcher(fetcher);
scrutinize(update);
assertWarningsRaised(QualifierCompatibilityScrutinizer.disallowedQualifiersType); assertWarningsRaised(QualifierCompatibilityScrutinizer.disallowedQualifiersType);
} }
@Test @Test
public void testMissingQualifier() { public void testMissingQualifier() {
scrutinize(makeStatement()); ItemIdValue idA = TestingData.existingId;
Snak mainSnak = Datamodel.makeSomeValueSnak(mandatoryPropertyIdValue);
Statement statement = makeStatement(mainSnak);
ItemUpdate update = new ItemUpdateBuilder(idA).addStatement(statement).build();
Snak snak1 = Datamodel.makeValueSnak(propertyParameterPID, propertyParameterValue);
List<Snak> snakList1 = Collections.singletonList(snak1);
SnakGroup snakGroup1 = Datamodel.makeSnakGroup(snakList1);
List<SnakGroup> snakGroupList = Collections.singletonList(snakGroup1);
List<Statement> statementList = constraintParameterStatementList(mandatoryQualifierEntity, snakGroupList);
ConstraintFetcher fetcher = mock(ConstraintFetcher.class);
when(fetcher.getConstraintsByType(mandatoryPropertyIdValue, "Q21510856")).thenReturn(statementList);
when(fetcher.findValues(snakGroupList, "P2306")).thenReturn(Collections.singletonList(qualifierProperty));
setFetcher(fetcher);
scrutinize(update);
assertWarningsRaised(QualifierCompatibilityScrutinizer.missingMandatoryQualifiersType); assertWarningsRaised(QualifierCompatibilityScrutinizer.missingMandatoryQualifiersType);
} }
@Test @Test
public void testGoodEdit() { public void testGoodEdit() {
scrutinize(makeStatement(allowedQualifier, mandatoryQualifier)); ItemIdValue idA = TestingData.existingId;
Snak mainSnak = Datamodel.makeSomeValueSnak(allowedPropertyIdValue);
Snak qualifierSnak = Datamodel.makeSomeValueSnak(qualifierProperty);
Statement statement = makeStatement(mainSnak, qualifierSnak);
ItemUpdate update = new ItemUpdateBuilder(idA).addStatement(statement).build();
Snak snak1 = Datamodel.makeValueSnak(propertyParameterPID, propertyParameterValue);
List<Snak> snakList1 = Collections.singletonList(snak1);
SnakGroup snakGroup1 = Datamodel.makeSnakGroup(snakList1);
List<SnakGroup> snakGroupList = Collections.singletonList(snakGroup1);
List<Statement> statementList = constraintParameterStatementList(allowedQualifierEntity, snakGroupList);
ConstraintFetcher fetcher = mock(ConstraintFetcher.class);
when(fetcher.getConstraintsByType(allowedPropertyIdValue, "Q21510851")).thenReturn(statementList);
when(fetcher.findValues(snakGroupList, "P2306")).thenReturn(Collections.singletonList(qualifierProperty));
setFetcher(fetcher);
scrutinize(update);
assertNoWarningRaised(); assertNoWarningRaised();
} }
private Statement makeStatement(Snak... qualifiers) { private Statement makeStatement(Snak mainSnak, Snak... qualifiers) {
Claim claim = Datamodel.makeClaim(TestingData.existingId, Claim claim = Datamodel.makeClaim(TestingData.existingId,
Datamodel.makeNoValueSnak(MockConstraintFetcher.mainSnakPid), makeQualifiers(qualifiers)); mainSnak, makeQualifiers(qualifiers));
return Datamodel.makeStatement(claim, Collections.emptyList(), StatementRank.NORMAL, ""); return Datamodel.makeStatement(claim, Collections.emptyList(), StatementRank.NORMAL, "");
} }