s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Reduced amount of logging.

Browse Source 
Suppressed logging for the GetProcessesCommand, which gets ping'ed often while there is a long running operation being executed (e.g., reconciling, fetching URLs).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2228 7d457c2a-affb-35e4-300a-418c747d4874
This commit is contained in:
David Huynh 2011-09-01 18:26:45 +00:00
parent b78d3f8bf4
commit a88ccd2c32
4 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
main/src/com/google/refine/RefineServlet.java
View File

@ -164,14 +164,14 @@ public class RefineServlet extends Butterfly {
Command command = commands.get(commandKey);
if (command != null) {
if (request.getMethod().equals("GET")) {
if (!logger.isTraceEnabled()) {
if (!logger.isTraceEnabled() && command.logRequests()) {
logger.info("GET {}", request.getPathInfo());
}
logger.trace("> GET {}", commandKey);
command.doGet(request, response);
logger.trace("< GET {}", commandKey);
} else if (request.getMethod().equals("POST")) {
if (!logger.isTraceEnabled()) {
if (!logger.isTraceEnabled() && command.logRequests()) {
logger.info("POST {}", request.getPathInfo());
}
logger.trace("> POST {}", commandKey);

9
main/src/com/google/refine/commands/Command.java
View File

@ -86,6 +86,15 @@ public abstract class Command {
throw new UnsupportedOperationException();
};
/**
* Whether each request to this command should be logged. For some commands
* that can get called too frequently, such as GetProcessesCommand, logging
* is very distracting.
*/
public boolean logRequests() {
return true;
}
/**
* Utility function to get the browsing engine's configuration as a JSON object
* from the "engine" request parameter, most often in the POST body.

5
main/src/com/google/refine/commands/history/GetProcessesCommand.java
View File

@ -57,4 +57,9 @@ public class GetProcessesCommand extends Command {
respondException(response, e);
}
}
@Override
public boolean logRequests() {
return false;
}
}

4
server/src/log4j.properties
View File

@ -5,3 +5,7 @@ log4j.logger.velocity=WARN
log4j.appender.console=org.apache.log4j.ConsoleAppender
log4j.appender.console.layout=com.google.util.logging.IndentingLayout
log4j.logger.butterfly=ERROR
log4j.logger.refine=INFO
log4j.logger.FileProjectManager=WARN