s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix issue #2320

Browse Source
This commit is contained in:
afkbrb 2020-02-28 11:57:03 +08:00
parent ffc8f5b63a
commit ab0c625f94
1 changed files with 28 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
extensions/wikidata/src/org/openrefine/wikidata/exporters/QuickStatementsExporter.java
View File

@ -151,21 +151,38 @@ public class QuickStatementsExporter implements WriterExporter {
Value val = claim.getValue(); Value val = claim.getValue();
ValueVisitor<String> vv = new QSValuePrinter(); ValueVisitor<String> vv = new QSValuePrinter();
String targetValue = val.accept(vv); String targetValue = val.accept(vv);
if (targetValue != null) { if (targetValue != null) { // issue #2320
if (!add) { if (!add) {
// According to: https://www.wikidata.org/wiki/Help:QuickStatements#Removing_statements,
// Removing statements won't be followed by qualifiers or references.
writer.write("- "); writer.write("- ");
} writer.write(qid + "\t" + pid + "\t" + targetValue);
writer.write(qid + "\t" + pid + "\t" + targetValue); writer.write("\n");
for (SnakGroup q : claim.getQualifiers()) { } else { // add statements
translateSnakGroup(q, false, writer); if (statement.getReferences().isEmpty()) {
} writer.write(qid + "\t" + pid + "\t" + targetValue);
for (Reference r : statement.getReferences()) { for (SnakGroup q : claim.getQualifiers()) {
for (SnakGroup g : r.getSnakGroups()) { translateSnakGroup(q, false, writer);
translateSnakGroup(g, true, writer); }
writer.write("\n");
} else {
// According to: https://www.wikidata.org/wiki/Help:QuickStatements#Add_statement_with_sources
// Existing statements with an exact match (property and value) will not be added again;
// however additional references might be added to the statement.
// So, to handle multiple references, we can duplicate the statement just with different references.
for (Reference r : statement.getReferences()) {
writer.write(qid + "\t" + pid + "\t" + targetValue);
for (SnakGroup q : claim.getQualifiers()) {
translateSnakGroup(q, false, writer);
}
for (SnakGroup g : r.getSnakGroups()) {
translateSnakGroup(g, true, writer);
}
writer.write("\n");
}
} }
break; // QS only supports one reference
} }
writer.write("\n");
} }
} }