From ad261109beb3ce3e7e9f037297c7fedd4a38a55f Mon Sep 17 00:00:00 2001
From: Antonin Delpeuch <antonin@delpeuch.eu>
Date: Tue, 24 Dec 2019 09:07:23 +0100
Subject: [PATCH] Fetch default recon service in background silently. Fixes
 #1665

---
 .../scripts/reconciliation/recon-manager.js   | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/main/webapp/modules/core/scripts/reconciliation/recon-manager.js b/main/webapp/modules/core/scripts/reconciliation/recon-manager.js
index ec0f3c848..23c379ba7 100644
--- a/main/webapp/modules/core/scripts/reconciliation/recon-manager.js
+++ b/main/webapp/modules/core/scripts/reconciliation/recon-manager.js
@@ -62,8 +62,11 @@ ReconciliationManager.registerService = function(service) {
   return ReconciliationManager.customServices.length - 1;
 };
 
-ReconciliationManager.registerStandardService = function(url, f) {
-  var dismissBusy = DialogSystem.showBusy($.i18n('core-recon/contact-service')+"...");
+ReconciliationManager.registerStandardService = function(url, f, silent) {
+  var dismissBusy = function() {};
+  if (!silent) {
+    dismissBusy =  DialogSystem.showBusy($.i18n('core-recon/contact-service')+"...");
+  }
 
   $.ajax(
     url,
@@ -90,8 +93,10 @@ ReconciliationManager.registerStandardService = function(url, f) {
     }
   })
   .error(function(jqXHR, textStatus, errorThrown) {
-    dismissBusy(); 
-    alert($.i18n('core-recon/error-contact')+': ' + textStatus + ' : ' + errorThrown + ' - ' + url);
+    if (!silent) {
+      dismissBusy(); 
+      alert($.i18n('core-recon/error-contact')+': ' + textStatus + ' : ' + errorThrown + ' - ' + url);
+    }
   });
 };
 
@@ -132,14 +137,14 @@ ReconciliationManager.save = function(f) {
   });
 };
 
-ReconciliationManager.getOrRegisterServiceFromUrl = function(url, f) {
+ReconciliationManager.getOrRegisterServiceFromUrl = function(url, f, silent) {
    var service = ReconciliationManager.getServiceFromUrl(url);
    if (service == null) {
       ReconciliationManager.registerStandardService(url, function(idx) {
           ReconciliationManager.save(function() {
               f(ReconciliationManager.standardServices[idx]);
           });
-      });
+      }, silent);
    } else {
       f(service);
    }  
@@ -148,7 +153,7 @@ ReconciliationManager.getOrRegisterServiceFromUrl = function(url, f) {
 ReconciliationManager.ensureDefaultServicePresent = function() {
    var lang = $.i18n('core-recon/wd-recon-lang');
    var url = "https://tools.wmflabs.org/openrefine-wikidata/"+lang+"/api";
-   ReconciliationManager.getOrRegisterServiceFromUrl(url, function(service) { });
+   ReconciliationManager.getOrRegisterServiceFromUrl(url, function(service) { }, true);
    return url;
 };