Fix scrolling in Wikidata schema

This commit is contained in:
Antonin Delpeuch 2018-04-20 19:51:33 +02:00
parent 60db2828a8
commit adfa60ef14
4 changed files with 25 additions and 14 deletions

View File

@ -8,11 +8,13 @@
<li><a href="#schema-alignment-tabs-preview-edits" bind="editsPreviewTabHeader"></a></li> <li><a href="#schema-alignment-tabs-preview-edits" bind="editsPreviewTabHeader"></a></li>
</ul> </ul>
<div id="schema-alignment-tabs-schema"> <div id="schema-alignment-tabs-schema">
<p class="body-text" bind="dialogExplanation"></p> <div bind="schemaHeader">
<div class="schema-alignment-dialog-canvas"> <p class="body-text" bind="dialogExplanation"></p>
<div class="schema-alignment-dialog-columns-area"> <div class="schema-alignment-dialog-columns-area" bind="columnsArea">
</div> </div>
<div class="schema-alignment-dialog-statements-area"> </div>
<div class="schema-alignment-dialog-canvas" bind="canvas">
<div class="schema-alignment-dialog-statements-area" bind="statementsArea">
<div id="schema-alignment-statements-container"> <div id="schema-alignment-statements-container">
</div> </div>
<div class="wbs-toolbar"><a class="wbs-add-item" bind="addItemButton"></a></div> <div class="wbs-toolbar"><a class="wbs-add-item" bind="addItemButton"></a></div>

View File

@ -195,6 +195,9 @@ SchemaAlignmentDialog.switchTab = function(targetTab) {
this._schemaPanel.height(panelHeight); this._schemaPanel.height(panelHeight);
this._issuesPanel.height(panelHeight); this._issuesPanel.height(panelHeight);
this._previewPanel.height(panelHeight); this._previewPanel.height(panelHeight);
// Resize the inside of the schema panel
var headerHeight = this._schemaElmts.schemaHeader.outerHeight();
this._schemaElmts.canvas.height(panelHeight - headerHeight - 10);
} }
SchemaAlignmentDialog.isSetUp = function() { SchemaAlignmentDialog.isSetUp = function() {

View File

@ -1,14 +1,17 @@
<div id="schema-alignment-tab"> <div id="schema-alignment-tab">
<div class="schema-alignment-save"><button class="button button-primary" bind="saveButton"></button><button class="button button-primary" bind="discardButton"></button></div> <div bind="schemaHeader">
<p class="panel-explanation" bind="dialogExplanation"></p> <div class="schema-alignment-save"><button class="button button-primary" bind="saveButton"></button><button class="button button-primary" bind="discardButton"></button></div>
<div class="schema-alignment-dialog-canvas"> <p class="panel-explanation" bind="dialogExplanation"></p>
<div class="schema-alignment-dialog-columns-area"> <div style="clear: right"></div>
</div> <div class="schema-alignment-dialog-columns-area" bind="columnsArea">
<div class="schema-alignment-dialog-statements-area">
<div id="schema-alignment-statements-container">
</div> </div>
<div class="wbs-toolbar"><a class="wbs-add-item" bind="addItemButton"></a></div>
</div> </div>
<div class="schema-alignment-dialog-canvas" bind="canvas">
<div class="schema-alignment-dialog-statements-area" bind="statementsArea">
<div id="schema-alignment-statements-container">
</div>
<div class="wbs-toolbar"><a class="wbs-add-item" bind="addItemButton"></a></div>
</div>
</div> </div>
</div> </div>

View File

@ -19,6 +19,10 @@
height: 100%; height: 100%;
} }
#schema-alignment-tab {
overflow: hidden;
}
.main-view-panel-tab-header { .main-view-panel-tab-header {
margin-top: 9px; margin-top: 9px;
margin-left: 7px; margin-left: 7px;
@ -41,9 +45,8 @@
} }
.schema-alignment-dialog-canvas { .schema-alignment-dialog-canvas {
padding: 0px
margin-top: 3px;
background: white; background: white;
overflow-y: auto;
} }
.schema-alignment-dialog-statements-area { .schema-alignment-dialog-statements-area {